Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Pin r-lib actions as a workaround for latest action updates #572

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

paleolimbot
Copy link
Member

First noticed at #555 (comment) , the R check action is failing because an update to r-lib actions resulted in some quarto actions being invoked, and these have not yet been whitelisted for use in Apache repositories. It also may be that we don't need the quarto actions (we probably don't) but some brief experimentation to attempt circumventing the use of the quarto action did not result in a successful workflow. Hence, a pin to unblock PR checks until either the v2 branch is updated or it is clear how to avoid the failure.

@paleolimbot paleolimbot marked this pull request as ready for review August 5, 2024 12:48
@paleolimbot
Copy link
Member Author

I'm going to merge this to unblock CI but feel free to leave comments and I'll circle back!

@paleolimbot paleolimbot merged commit e83db82 into apache:main Aug 5, 2024
11 checks passed
@paleolimbot paleolimbot deleted the ci-r-actions-pin branch August 5, 2024 18:53
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I speculate (without checking :D) that the issue is that even if the action skips the quarto related action the gh runner will still attempt to fetch all actions in - uses: tags.

I'll see if there is either a way to go around that or get the action allowlisted.

@jiayuasu
Copy link
Member

@paleolimbot We had the same issue at Sedona R: apache/sedona#1537

If this is a very important action, we can create an ASF infra ticket on JIRA and ask ASF together to whitelist it. We did it once before.

@assignUser
Copy link
Member

assignUser commented Aug 13, 2024

@jiayuasu there is an open infra ticket to allow the quarto action: https://issues.apache.org/jira/projects/INFRA/issues/INFRA-26031

@assignUser
Copy link
Member

This issue is fixed now!

@paleolimbot paleolimbot added this to the nanoarrow 0.6.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants