Skip to content

Commit

Permalink
clarify inlining more
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb committed Oct 16, 2024
1 parent cb5627e commit b32679a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arrow/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ discovering the auto-vectorized code was faster.
LLVM is relatively good at vectorizing vertical operations provided:

1. No conditionals within the loop body (e.g no checking for nulls on each row)
2. Not too much `#[inline]` (as the vectorizer gives up if the code is too complex)
2. Not too much inlining (judicious use of #[inline] and #[inline(never)]) as the vectorizer gives up if the code is too complex
3. No [horizontal reductions] or data dependencies
4. Suitable SIMD instructions available in the target ISA (e.g. `target-cpu` `RUSTFLAGS` flag)

Expand Down

0 comments on commit b32679a

Please sign in to comment.