-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AmazonS3Builder::from_env to populate credentials from environment #2361
Comments
I can help on this one. Is it better to bring a full support of the builder properties through environment or just the minimum to leverage AWS_* regular environment setup? Solution 1 we bring everything from environment but we need to introduce new variables to match each builder properties. let object_store = AmazonS3Builder::from_env().build();
// or even ?
let object_store = AmazonS3::from_env(); Solution 2 we match existing AWS variable and provide support for AWS_* variables described there let object_store = AmazonS3Builder::from_env()
.with_bucket_name("the-bucket-name")
.with_allow_http(true); Solution 3 we support only the 4 variables used in integration test for now Which one is the most suitable for you? |
Thank you for volunteering, I think option 2 makes the most sense. Specifically where one of the builder options has a standard The idea is to get people up and running quickly, much like the standard AWS SDKs, not necessarily to expose the full set of customisation supported by this crate as environment variables, nor necessarily to support the full set of configuration supported by the CLI (e.g. I don't anticipate supporting AWS_CONFIG for example). |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
There are various common environment variables for configuring AWS credentials, e.g.
AWS_SECRET_ACCESS_KEY
,AWS_REGION
, etc... We should add afrom_env
method that respects theseDescribe the solution you'd like
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: