Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support accessing ipc Reader/Writer inner by reference #4121

Closed
sticnarf opened this issue Apr 25, 2023 · 0 comments · Fixed by #4122
Closed

Support accessing ipc Reader/Writer inner by reference #4121

sticnarf opened this issue Apr 25, 2023 · 0 comments · Fixed by #4122
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@sticnarf
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Our own Reader passed into arrow_ipc::reader::FileReader includes statistics, and we need to collect statistics during iterating the reader. Therefore, we need to access the inner reader through arrow_ipc::reader::FileReader.

Describe the solution you'd like

Add get_ref and get_mut methods to ipc readers and writers.

Describe alternatives you've considered

Wrapping our own reader or writer with Arc<Mutex>.

Additional context
@sticnarf sticnarf added the enhancement Any new improvement worthy of a entry in the changelog label Apr 25, 2023
@sticnarf sticnarf mentioned this issue Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add get_{ref, mut} to arrow_ipc Reader and Writer sticnarf/arrow-rs
1 participant
@sticnarf