feat: add get_{ref, mut} to arrow_ipc Reader and Writer #4122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
sticnarf
changed the title
tustvold
approved these changes
Apr 25, 2023
|
|
||
| /// Gets a mutable reference to the underlying reader. | ||
| /// | ||
| /// It is inadvisable to directly read from the underlying reader. |
Comment on lines
+1043
to
+1044
| /// | ||
| /// It is inadvisable to directly read from the underlying reader. |
There was a problem hiding this comment.
Suggested change
| /// | |
| /// It is inadvisable to directly read from the underlying reader. |
Reading requires mutable access so this comment is possibly redundant
There was a problem hiding this comment.
Sometimes reading doesn't require a mutable reference (e.g. &File implements Read), so I think the comment is worth having.
Comment on lines
+1262
to
+1263
| /// | ||
| /// It is inadvisable to directly read from the underlying reader. |
There was a problem hiding this comment.
Suggested change
| /// | |
| /// It is inadvisable to directly read from the underlying reader. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4121.
Rationale for this change
What changes are included in this PR?
The
BufReaderandBufWriterin Ruststdhave similar methods.Are there any user-facing changes?