Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error with simd feature #1169

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

jhorstmann
Copy link
Contributor

Which issue does this PR close?

Fixes a compilation error introduced in the last commit of PR #1161

That commit was supposed to only add some comments, but I also removed one unneeded Result return type and did not try to compile with the simd feature afterwards.

cc @alamb

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 13, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jhorstmann

All the tests passed on 68e5750

so that this is broken on master is surprising to me. Maybe it was a logical conflict 🤷

@alamb
Copy link
Contributor

alamb commented Jan 13, 2022

FWIW I think a new version of rust (1.58) was released which is likely breaking some of the CI tests on master

@jhorstmann
Copy link
Contributor Author

Ah, I see there was also multiply_scalar introduced at nearly the same time, so it was the combination that failed.

@jhorstmann
Copy link
Contributor Author

Looks like the test failures on master are due to an intentional change in rust: rust-lang/rust@8731d4d#diff-363ad34c0858be71721f73b0880238813baf8f8b36ebbb494baa6b29103dd8d5

I don't know why we assert that exact formatting though. Also seems intentional because there is a range check in fmt::Display for parquet::record::api.

@alamb alamb merged commit 5fb0534 into apache:master Jan 14, 2022
@alamb
Copy link
Contributor

alamb commented Jan 14, 2022

Thanks @jhorstmann -- I'll get a PR up to fix the last error

@alamb
Copy link
Contributor

alamb commented Jan 14, 2022

Looks like the test failures on master are due to an intentional change in rust: rust-lang/rust@8731d4d#diff-363ad34c0858be71721f73b0880238813baf8f8b36ebbb494baa6b29103dd8d5

PR to fix the tests: #1173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants