Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for overriding instance metadata endpoint #2811

Merged
merged 3 commits into from
Oct 1, 2022

Conversation

wjones127
Copy link
Member

@wjones127 wjones127 commented Sep 30, 2022

Which issue does this PR close?

Closes #2802.

Rationale for this change

Support getting credentials in AWS ECS.

What changes are included in this PR?

As suggested, allows user to set instance metadata endpoint. Extract from the documented environment variable.

Are there any user-facing changes?

Yes, new methods on the AWS builder. I have added docs here and verified the rendered output looks good.

@github-actions github-actions bot added the object-store Object Store Interface label Sep 30, 2022
@wjones127 wjones127 marked this pull request as draft September 30, 2022 03:52
@wjones127
Copy link
Member Author

(whoops ran cargo test and not cargo test --features aws 🤦 )

@wjones127 wjones127 marked this pull request as ready for review September 30, 2022 04:17
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits

object_store/src/aws/mod.rs Outdated Show resolved Hide resolved
object_store/src/aws/mod.rs Outdated Show resolved Hide resolved
@tustvold tustvold changed the title Support for setting instance metadata endpoint Support for overriding instance metadata endpoint Sep 30, 2022
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@tustvold tustvold merged commit 3999c77 into apache:master Oct 1, 2022
@ursabot
Copy link

ursabot commented Oct 1, 2022

Benchmark runs are scheduled for baseline = 6477db1 and contender = 3999c77. 3999c77 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

object_store: support AWS ECS instance credentials
3 participants