object_store: add support for using proxy_url for connection testing #3109
Conversation
sum12
force-pushed
the
proxy-for-objectstorage
branch
2 times, most recently
from
1843c0d to
25558d9
Compare
sum12
force-pushed
the
proxy-for-objectstorage
branch
2 times, most recently
from
2ca5ac1 to
35e9482
Compare
|
added some unit-test. tried it against a local socks5 server |
sum12
force-pushed
the
proxy-for-objectstorage
branch
from
35e9482 to
cbfd34c
Compare
| @@ -561,6 +571,14 @@ impl AmazonS3Builder { | |||
| let bucket = self.bucket_name.context(MissingBucketNameSnafu)?; | |||
| let region = self.region.context(MissingRegionSnafu)?; | |||
|
|
|||
| let clientbuilder = match self.proxy_url { | |||
There was a problem hiding this comment.
This currently only alters the client used to obtain credentials, it does not alter the client created in S3Client::new which likely needs the same treatment as AzureClient
There was a problem hiding this comment.
done, thanks for the review :-)
|
Is this PR ready to go? |
sum12
force-pushed
the
proxy-for-objectstorage
branch
from
cbfd34c to
a1c7906
Compare
|
Benchmark runs are scheduled for baseline = 1d6b5ab and contender = b2bfe9c. b2bfe9c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2989
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?