Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object_store): add PrefixObjectStore #3329

Merged
merged 4 commits into from
Dec 12, 2022
Merged

Conversation

roeap
Copy link
Contributor

@roeap roeap commented Dec 12, 2022

Which issue does this PR close?

Closes #3328

Rationale for this change

see #3328

What changes are included in this PR?

Adds a new PrefixObjectStore

Are there any user-facing changes?

yes, a new object store wrapper is available :)

@github-actions github-actions bot added the object-store Object Store Interface label Dec 12, 2022
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits

object_store/src/prefix.rs Outdated Show resolved Hide resolved
object_store/src/prefix.rs Outdated Show resolved Hide resolved
object_store/src/prefix.rs Outdated Show resolved Hide resolved
object_store/src/prefix.rs Outdated Show resolved Hide resolved
Comment on lines 122 to 125
let prefix = prefix.and_then(|p| self.full_path(p).ok());
Ok(self
.inner
.list(Some(&prefix.unwrap_or_else(|| self.prefix.clone())))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be simpler with just a basic match

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure, if my update here is what you had in mind :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see what complicates this - suggestion in https://github.com/apache/arrow-rs/pull/3329/files#r1045836725

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much cleaner with infallible full_path - hope that's what you had in mind.

roeap and others added 2 commits December 12, 2022 13:20
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@tustvold tustvold merged commit 225ea93 into apache:master Dec 12, 2022
@roeap roeap deleted the prefix branch December 12, 2022 16:41
@ursabot
Copy link

ursabot commented Dec 13, 2022

Benchmark runs are scheduled for baseline = ad94368 and contender = 225ea93. 225ea93 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a constant prefix object store wrapper
3 participants