feat: Allow providing a service account key directly for GCS #3489
Conversation
Use case: We're storing service accounts keys external to where the object store client is being created. We do not want to have to write the key to a file before creating the object store client. This change allows for providing the key directly.
|
Thank you, makes sense to me.
Yeah, probably not worth introducing a breaking change over, but perhaps we could deserialize "service_account_path" and "google_service_account_path" to allow for users to opt-in to using a more explicit config key. What do you think? |
"google_service_account_path" and "service_account_path" can now be used.
Seems reasonable to me. Latest commit has those included. |
|
Benchmark runs are scheduled for baseline = c746658 and contender = eae993f. eae993f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3488
Rationale for this change
Use case:
We're storing service accounts keys external to where the object store client is
being created. We do not want to have to write the key to a file before creating
the object store client. This change allows for providing the key directly.
What changes are included in this PR?
Adds an appropriate method to the GCS object store builder for supplying the service account key directly. Only one of service account path or service account key may be provided, otherwise
buildwill return an appropriate error.Are there any user-facing changes?
An additional method on GCS object store builder.
There are currently no breaking changes, however I believe the
ServiceAccountvariant for theGoogleConfigKeyshould be renamed toServiceAccountPathto better represent what that option is for. I held off on making that change because I saw that the changelog was already generated for 0.5.3 which includes the newGoogleConfigKeystuff, making that a breaking change. If that's an acceptable breaking change, I'm down to go ahead and do that in this PR as well.