Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter exact list prefix matches for azure gen2 accounts #3714

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

roeap
Copy link
Contributor

@roeap roeap commented Feb 14, 2023

Which issue does this PR close?

Part of #3712

again, no straight forward way to test this in CI without a gen2 account, but tested it locally.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the object-store Object Store Interface label Feb 14, 2023
@roeap
Copy link
Contributor Author

roeap commented Feb 14, 2023

I know the latest object store release is just a week old, but there are some fixes and features on master I am keen to integrate. Would it be possible to cut another object store release soon?

object_store/src/azure/client.rs Outdated Show resolved Hide resolved
@tustvold
Copy link
Contributor

Would it be possible to cut another object store release soon?

I can look to cut a release once this is in

Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@roeap
Copy link
Contributor Author

roeap commented Feb 14, 2023

I seem to not be able to re-start the failing tests, but to me it seems is just a bit of flakiness in connecting to localstack.

@tustvold tustvold merged commit ef00365 into apache:master Feb 14, 2023
@ursabot
Copy link

ursabot commented Feb 14, 2023

Benchmark runs are scheduled for baseline = 38a79ae and contender = ef00365. ef00365 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@roeap roeap deleted the fix-azure-list branch February 14, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants