Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Specify content length for gcp copy request #3921

Merged
merged 2 commits into from
Mar 23, 2023
Merged

fix: Specify content length for gcp copy request #3921

merged 2 commits into from
Mar 23, 2023

Conversation

scsmithr
Copy link
Contributor

@scsmithr scsmithr commented Mar 23, 2023 •
edited
Loading

Which issue does this PR close?

N/A

This fixes an issue where copy requests for the GCS object store would error due to a missing content-length header.

Rationale for this change

We hit "Error 411 (Length Required)" on the copyTo endpoint when calling copy_if_not_exists for the GCS object store.

An example error response that we get:

"Generic GCS error: Error performing copy request databases/00000000-0000-0000-0000-000000000000/tmp/299e25c3-a5f5-445c-97ca-28f37f64fb29/lease: response error \"<!DOCTYPE html>\n<html lang=en>\n  <meta charset=utf-8>\n  <meta name=viewport content=\"initial-scale=1, minimum-scale=1, width=device-width\">\n  <title>Error 411 (Length Required)!!1</title>\n  <style>\n    *{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px}* > body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/branding/googlelogo/1x/googlelogo_color_150x54dp.png) no-repeat;margin-left:-5px}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:54px;width:150px}\n  </style>\n  <a href=//www.google.com/><span id=logo aria-label=Google></span></a>\n  <p><b>411.</b> <ins>That’s an error.</ins>\n  <p>POST requests require a <code>Content-length</code> header.  <ins>That’s all we know.</ins>\n\", after 0 retries: HTTP status client error (411 Length Required) for url (https://storage.googleapis.com/storage/v1/b/sean-test-glaredb/o/databases/00000000-0000-0000-0000-000000000000/tmp/299e25c3-a5f5-445c-97ca-28f37f64fb29/lease/copyTo/b/sean-test-glaredb/o/databases/00000000-0000-0000-0000-000000000000/visible/lease?ifGenerationMatch=0)"

Getting a reproducible test case for this has been incredibly tricky. We believe that it comes down to whether or not the object_store crate gets compiled with native-tls or rust-tls. See https://github.com/RustomMS/test-object-store for our best shot at reproducing.

I also believe that this change would fix this issue delta-io/delta-rs#878.

What changes are included in this PR?

Explicitly sets content-length to 0 for GCS copyTo request.

Are there any user-facing changes?

No.

@github-actions github-actions bot added the object-store Object Store Interface label Mar 23, 2023
scsmithr added a commit to GlareDB/glaredb that referenced this pull request Mar 23, 2023
@scsmithr
fix: Use patched object store to fix content-length error
59ad34a 
See apache/arrow-rs#3921
@scsmithr scsmithr mentioned this pull request Mar 23, 2023
Merged
scsmithr added a commit to GlareDB/glaredb that referenced this pull request Mar 23, 2023
@scsmithr
fix: Use patched object store to fix content-length error (#761)
a10b07a 
See apache/arrow-rs#3921
tustvold
tustvold approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this was originally included in https://github.com/apache/arrow-rs/pull/3236/files/2033d5aba91a15bda5d5f7d5f5151e96ac99a2f8#r1037123180 but was reverted as I couldn't find a way to reproduce it

@tustvold
Copy link
Contributor

Thank you for debugging this, I can reproduce this locally, wild 😅

@scsmithr @tustvold
Include comment about native-tls/rust-tls
983ddb7 
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@scsmithr
Copy link
Contributor Author

Thank you for debugging this, I can reproduce this locally, wild 😅

Yeah we were quite confused too. Still don't know why that happens though...

@tustvold
Copy link
Contributor

Still don't know why that happens though...

Might be worth raising an issue on reqwest to see if they have any ideas what might be causing it

@tustvold tustvold merged commit bcfe63e into apache:master Mar 23, 2023
@wjones127 wjones127 mentioned this pull request Apr 8, 2023
Closed
@hiltontj hiltontj mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scsmithr @tustvold