Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect validation logic on S3 bucket names #3947

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

rtyler
Copy link
Contributor

@rtyler rtyler commented Mar 26, 2023

S3 bucket names can have dots in them, see this documentation

Bucket names can consist only of lowercase letters, numbers, dots (.), and hyphens (-).

This was originally reported in delta-io/delta-rs#1239 by @gray-sat

S3 bucket names can have dots in them, see [this
documentation](https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html)

> Bucket names can consist only of lowercase letters, numbers, dots (.), and hyphens (-).

This was originally reported in delta-io/delta-rs#1239 by @gray-sat
@github-actions github-actions bot added the object-store Object Store Interface label Mar 26, 2023
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

FYI @roeap

@tustvold tustvold merged commit 62919cf into apache:master Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants