Store StructArray entries in MapArray #4085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
tustvold
commented
Apr 13, 2023
| @@ -175,7 +175,7 @@ impl LevelInfoBuilder { | |||
| } | |||
|
|
|||
| /// Given an `array`, write the level data for the elements in `range` | |||
| fn write(&mut self, array: &ArrayRef, range: Range<usize>) { | |||
| fn write(&mut self, array: &dyn Array, range: Range<usize>) { | |||
There was a problem hiding this comment.
This change is necessary because MapArray::entries now returns StructArray instead of &ArrayRef
tustvold
commented
Apr 13, 2023
| } | ||
|
|
||
| /// Returns a reference to the [`StructArray`] entries of this map | ||
| pub fn entries(&self) -> &ArrayRef { | ||
| pub fn entries(&self) -> &StructArray { |
There was a problem hiding this comment.
This is a breaking change, but I think is significantly easier to understand, especially since it was already documented to be a StructArray 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This was something that came up on #4061 (comment)
Not only was the previous formulation redundant, but also was unnecessarily confusing
What changes are included in this PR?
Are there any user-facing changes?