Extract Common Listing and Retrieval Functionality #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
May 15, 2023
| @@ -302,89 +268,6 @@ impl S3Client { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Make an S3 List request <https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html> | |||
| async fn list_request( | |||
There was a problem hiding this comment.
This is just moved
tustvold
commented
May 15, 2023
| @@ -169,40 +169,6 @@ impl S3Client { | |||
| self.config.credentials.get_credential().await | |||
| } | |||
|
|
|||
| /// Make an S3 GET request <https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html> | |||
| pub async fn get_request( | |||
There was a problem hiding this comment.
This is moved to be a trait implementation
tustvold
commented
May 15, 2023
| } | ||
|
|
||
| /// Perform a list operation automatically handling pagination | ||
| pub fn list_paginated( |
There was a problem hiding this comment.
This is now implemented by ListClientExt
tustvold
commented
May 15, 2023
| @@ -0,0 +1,85 @@ | |||
| // or more contributor license agreements. See the NOTICE file | |||
There was a problem hiding this comment.
This is just moved from list.rs
alamb
approved these changes
May 17, 2023
| ) -> Result<(ListResult, Option<String>)> { | ||
| assert!(offset.is_none()); // Not yet supported |
There was a problem hiding this comment.
This should return an error rather than panic'ing I think
There was a problem hiding this comment.
It is unreachable by the current code
| use reqwest::Response; | ||
|
|
||
| #[async_trait] | ||
| pub trait GetClient: Send + Sync + 'static { |
There was a problem hiding this comment.
I think some this should have some comments / explination for what it is doing
| @@ -346,22 +358,6 @@ impl AzureClient { | |||
|
|
|||
| Ok((to_list_result(response, prefix)?, token)) | |||
| } | |||
|
|
|||
| /// Perform a list operation automatically handling pagination | |||
There was a problem hiding this comment.
This is now implemented indirectly via ListClientExt
tustvold
added a commit
to tustvold/arrow-rs
that referenced
this pull request
May 18, 2023
tustvold
added a commit
that referenced
this pull request
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Extracts common listing and get functionality from the various cloud ObjectStore. This ends up being more code, but avoids duplication and so I think is probably better, would appreciate any thoughts?
What changes are included in this PR?
Are there any user-facing changes?