Standardise credentials API (#4223) (#4163) #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
May 16, 2023
| @@ -503,6 +506,90 @@ impl GetOptionsExt for RequestBuilder { | |||
| } | |||
| } | |||
|
|
|||
| /// Provides credentials for use when signing requests | |||
| #[async_trait] | |||
| pub trait CredentialProvider: std::fmt::Debug + Send + Sync { | |||
There was a problem hiding this comment.
This is the interface that will be made public as part of #4163
roeap
approved these changes
May 16, 2023
| /// Fetch a token | ||
| async fn fetch_token( | ||
| &self, | ||
| client: &Client, | ||
| retry: &RetryConfig, | ||
| ) -> Result<TemporaryToken<String>> { | ||
| ) -> crate::Result<TemporaryToken<Arc<AzureCredential>>> { |
There was a problem hiding this comment.
Suggested change
| ) -> crate::Result<TemporaryToken<Arc<AzureCredential>>> { | |
| ) -> crate::Result<TemporaryToken<Arc<Self::Credential>>> { |
probably not worth the change, but I find this a little bit more explicit when reading the code.
There was a problem hiding this comment.
I think I prefer being explicit about the type returned
This was referenced May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4223
Part of #4163
Rationale for this change
In order to expose extension points that relate to authorization and credentials, it helps to have a standard abstraction for representing this.
What changes are included in this PR?
Are there any user-facing changes?