Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSRV CI #4671

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fix MSRV CI #4671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@ jobs:
- name: Check arrow-flight
working-directory: arrow-flight
run: cargo msrv verify
- name: Downgrade object_store dependencies
working-directory: object_store
# Necessary because 1.30.0 updates MSRV to 1.63
run: cargo update -p tokio --precise 1.29.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other options would be to:

  • Add a maximum version constraint
  • Check in a lockfile

But both of these have obvious drawbacks, this seemed relatively unintrusive. Hopefully at some point cargo will add MSRV aware resolution so these sort of shenanigans will be handled automatically - rust-lang/cargo#9930

- name: Check object_store
working-directory: object_store
run: cargo msrv verify