Cleanup parquet type builders #4706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Aug 16, 2023
| pub fn with_fields(mut self, fields: &mut Vec<TypePtr>) -> Self { | ||
| self.fields.append(fields); | ||
| self | ||
| pub fn with_fields(self, fields: Vec<TypePtr>) -> Self { |
There was a problem hiding this comment.
Accepting &mut Vec<TypePtr> made for a very unusual interface, changing to accept Vec<TypePtr> is much "normal"
tustvold
commented
Aug 16, 2023
| pub fn with_id(mut self, id: i32) -> Self { | ||
| self.id = Some(id); | ||
| self | ||
| pub fn with_id(self, id: Option<i32>) -> Self { |
There was a problem hiding this comment.
This makes with_id consistent with the other APIs such as with_logical_type and with_converted_type (where ConvertedType has implicit nullability as a result of ConvertedType::NONE`). It also reflects the fact this setting is most often optional
crepererum
approved these changes
Aug 17, 2023
alamb
reviewed
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Noticed whilst investigating #4702
What changes are included in this PR?
Are there any user-facing changes?
The apis for some of setters of
PrimitiveTypeBuilderhave changed