Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate null_regex for string type in csv (now such values will be parsed as Null rather than "") #4942

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

haohuaijin
Copy link
Contributor

Which issue does this PR close?

Closes #4939

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 16, 2023
arrow-csv/src/reader/mod.rs Outdated Show resolved Hide resolved
@tustvold tustvold added the api-change Changes to the arrow API label Oct 16, 2023
@tustvold tustvold changed the title fix: add null_regex for string type in csv Evaluate null_regex for string type in csv Oct 16, 2023
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@alamb alamb changed the title Evaluate null_regex for string type in csv Evaluate null_regex for string type in csv (now such values will be parsed as Null rather than "") Oct 16, 2023
@tustvold tustvold merged commit 95b015c into apache:master Oct 16, 2023
23 checks passed
@haohuaijin haohuaijin deleted the null_regex_string branch October 17, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we make blank values and empty string to None in csv?
2 participants