Pull container name from URL for Azure blob #5371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….core.windows.net/<container> case
tustvold
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blob URLs within Azure have the container name as the first path parameter when formatted in this way:
https://<account>.blob.core.windows.net/<container>/caseWhich issue does this PR close?
Closes #5370
Rationale for this change
This is support for an additional blob URL format that is provided directly from Azure.
What changes are included in this PR?
An additional test case for this format as well as an additional parsing step when the url scheme matches
httpsand when the hostname matchesdfs.core.windows.netorblob.core.windows.netAre there any user-facing changes?
Users with blob URLs in this format will no longer need to manually provide the container when using
from_url