-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parquet Statistics - deprecate has_*
APIs and add _opt
functions that return Option<T>
#6216
Commits on Aug 9, 2024
-
update public api Statistics::min to return an option.
I first re-named the existing method to `min_unchecked` and made it internal to the crate. I then added a `pub min(&self) -> Opiton<&T>` method. I figure we can first change the public API before deciding what to do about internal usage. Ref: apache#6093
Configuration menu - View commit details
-
Copy full SHA for fd2ac15 - Browse repository at this point
Copy the full SHA fd2ac15View commit details -
update public api Statistics::max to return an option.
I first re-named the existing method to `max_unchecked` and made it internal to the crate. I then added a `pub max(&self) -> Opiton<&T>` method. I figure we can first change the public API before deciding what to do about internal usage. Ref: apache#6093
Configuration menu - View commit details
-
Copy full SHA for 18b467b - Browse repository at this point
Copy the full SHA 18b467bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ffac1a - Browse repository at this point
Copy the full SHA 7ffac1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87c375a - Browse repository at this point
Copy the full SHA 87c375aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6950994 - Browse repository at this point
Copy the full SHA 6950994View commit details -
Configuration menu - View commit details
-
Copy full SHA for c65a773 - Browse repository at this point
Copy the full SHA c65a773View commit details -
make Statistics::null_count return Option<u64>
This removes ambiguity around whether the between all values are non-null or just that the null count stat is missing Ref: apache#6215
Configuration menu - View commit details
-
Copy full SHA for 89ea21d - Browse repository at this point
Copy the full SHA 89ea21dView commit details -
update expected metadata memory size tests
Changing null_count from u64 to Option<u64> increases the memory size and layout of the metadata. I included these tests as a separate commit to call extra attention to it.
Configuration menu - View commit details
-
Copy full SHA for f2785f8 - Browse repository at this point
Copy the full SHA f2785f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a4921f - Browse repository at this point
Copy the full SHA 9a4921fView commit details
Commits on Aug 13, 2024
-
Apply suggestions from code review
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Configuration menu - View commit details
-
Copy full SHA for 7e082a7 - Browse repository at this point
Copy the full SHA 7e082a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddd8498 - Browse repository at this point
Copy the full SHA ddd8498View commit details -
rename new optional ValueStatistics::max to max_opt
Per PR review, we will deprecate the old API instead of introducing a brekaing change. Ref: apache#6216 (review)
Configuration menu - View commit details
-
Copy full SHA for e92321b - Browse repository at this point
Copy the full SHA e92321bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4db777 - Browse repository at this point
Copy the full SHA e4db777View commit details -
add Statistics:{min,max}_bytes_opt
This adds the API and migrates all of the test usage. The old APIs will be deprecated next.
Configuration menu - View commit details
-
Copy full SHA for bd83a38 - Browse repository at this point
Copy the full SHA bd83a38View commit details
Commits on Aug 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4e2909b - Browse repository at this point
Copy the full SHA 4e2909bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f3e21e - Browse repository at this point
Copy the full SHA 2f3e21eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 050ba89 - Browse repository at this point
Copy the full SHA 050ba89View commit details -
remove has_min_max_set check from make_decimal_stats_iterator
The check is unnecessary now that the stats funcs return Option<T> when unset.
Configuration menu - View commit details
-
Copy full SHA for fc0ed20 - Browse repository at this point
Copy the full SHA fc0ed20View commit details -
An internal version was also created because it is used so extensively in testing.
Configuration menu - View commit details
-
Copy full SHA for 2366942 - Browse repository at this point
Copy the full SHA 2366942View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82b40b8 - Browse repository at this point
Copy the full SHA 82b40b8View commit details -
remove redundant test assertions of stats._internal_has_min_max_set
This removes the assertion from any test that subsequently unwraps both min_opt and max_opt.
Configuration menu - View commit details
-
Copy full SHA for 3efc631 - Browse repository at this point
Copy the full SHA 3efc631View commit details -
replace negated test assertions of stats._internal_has_mix_max_set wi…
…th assertions on min_opt and max_opt This removes all use of Statistics::_internal_has_min_max_set from the code base, and so it is also removed.
Configuration menu - View commit details
-
Copy full SHA for a23cf8b - Browse repository at this point
Copy the full SHA a23cf8bView commit details
Commits on Aug 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7d4e650 - Browse repository at this point
Copy the full SHA 7d4e650View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48a35d3 - Browse repository at this point
Copy the full SHA 48a35d3View commit details