Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs[object_store]: clarify the backoff strategy that is actually implemented #6325

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

westonpace
Copy link
Member

Which issue does this PR close?

Closes #6324

Rationale for this change

This changes the description in the docs to match the implementation.

What changes are included in this PR?

Docs clarification

Are there any user-facing changes?

No

@github-actions github-actions bot added the object-store Object Store Interface label Aug 28, 2024
@westonpace westonpace requested a review from tustvold August 28, 2024 21:26
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backoff is exponential and this should be documented

object_store/src/client/backoff.rs Outdated Show resolved Hide resolved
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@tustvold tustvold merged commit 6785170 into apache:master Aug 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Document Backoff Algorithm
2 participants