Add ParquetMetaDataReader
#6431
Open
+956
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etseidl
commented
Sep 20, 2024
Comment on lines
+240
to
+243
| // TODO(ets): what is the correct behavior for missing page indexes? MetadataLoader would | ||
| // leave them as `None`, while the parser in `index_reader::read_columns_indexes` returns a | ||
| // vector of empty vectors. | ||
| // I think it's best to leave them as `None`. |
There was a problem hiding this comment.
This is the remaining outstanding issue from #6392. My preference is to leave the page indexes as None if they are not present, but this differs from current behavior.
… pq_metadata_reader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to #6002.
Rationale for this change
Consolidate Parquet metadata parsing into a single API. See discussion in #6392 for additional context.
What changes are included in this PR?
Adds the
ParquetMetaDataReaderstruct.Are there any user-facing changes?
No