Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Utf8View for bit_length kernel #6671

Merged
merged 9 commits into from
Nov 5, 2024
36 changes: 36 additions & 0 deletions arrow-string/src/length.rs
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,26 @@ pub fn bit_length(array: &dyn Array) -> Result<ArrayRef, ArrowError> {
let list = array.as_string::<i64>();
Ok(bit_length_impl::<Int64Type>(list.offsets(), list.nulls()))
}
DataType::Utf8View => {
let string_view_array = array
.as_any()
.downcast_ref::<StringViewArray>()
.ok_or_else(|| ArrowError::ComputeError("Expected Utf8View array".to_string()))?;
austin362667 marked this conversation as resolved.
Show resolved Hide resolved
let mut bit_lengths = Vec::with_capacity(array.len());
for i in 0..array.len() {
let bit_length = if string_view_array.is_valid(i) {
(string_view_array.value(i).len() * 8) as i32
austin362667 marked this conversation as resolved.
Show resolved Hide resolved
} else {
0
};
bit_lengths.push(bit_length);
}

Ok(Arc::new(Int32Array::new(
bit_lengths.into(),
array.nulls().cloned(),
)))
}
DataType::Binary => {
let list = array.as_binary::<i32>();
Ok(bit_length_impl::<Int32Type>(list.offsets(), list.nulls()))
Expand Down Expand Up @@ -462,6 +482,22 @@ mod tests {
})
}

#[test]
fn bit_length_test_utf8view() {
bit_length_cases()
austin362667 marked this conversation as resolved.
Show resolved Hide resolved
.into_iter()
.for_each(|(input, len, expected)| {
let string_array = StringViewArray::from(input);
let result = bit_length(&string_array).unwrap();
assert_eq!(len, result.len());

let result = result.as_any().downcast_ref::<Int32Array>().unwrap();
expected.iter().enumerate().for_each(|(i, value)| {
assert_eq!(*value, result.value(i));
});
})
}

#[test]
fn bit_length_binary() {
let value: Vec<&[u8]> = vec![b"one", &[0xff, 0xf8], b"three"];
Expand Down
Loading