-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Binary
arrays in starts_with
, ends_with
and contains
#6926
Merged
Merged
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ba959bb
add binary support in arrow-string
rluvaton 9dc6947
cleanup
rluvaton 4d5c350
remove BinaryArrayType
rluvaton 20b03b1
format
rluvaton 9237d25
avoid duplicate code even more
rluvaton e32425e
try to add back as much original code as possible
rluvaton 333ecb9
reorder functions to have less diff
rluvaton 1a695fb
remove use of impl Trait from function return type
rluvaton 30b432e
remove use of impl Trait from function return type
rluvaton 72d4ee2
Merge branch 'main' into add-example-arrow-binary-crate
rluvaton 0698655
revert like and predicate changes and add back as separate files
rluvaton a0abadb
format
rluvaton ac19ec3
run arrow
rluvaton bbb0b7f
update comment
rluvaton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the need to check a binary array for ASCII -- there shouldn't be any optimizations that rely on the data being ASCII
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because I did not want to duplicate the whole like and predicate file I implemented like and this needed for the like impl.
But instead I only implemented the contains, start with, and ends with