Skip to content

Commit

Permalink
sync recipe
Browse files Browse the repository at this point in the history
  • Loading branch information
h-vetinari committed Sep 17, 2023
1 parent f0b2133 commit 3584b5d
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 7 deletions.
2 changes: 1 addition & 1 deletion dev/tasks/conda-recipes/arrow-cpp/build-arrow.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ fi
# Enable CUDA support
if [[ ! -z "${cuda_compiler_version+x}" && "${cuda_compiler_version}" != "None" ]]
then
EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_CUDA=ON -DCUDA_TOOLKIT_ROOT_DIR=${CUDA_HOME} -DCMAKE_LIBRARY_PATH=${CONDA_BUILD_SYSROOT}/lib"
EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_CUDA=ON -DCUDAToolkit_ROOT=${CUDA_HOME} -DCMAKE_LIBRARY_PATH=${CONDA_BUILD_SYSROOT}/lib"
else
EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_CUDA=OFF"
fi
Expand Down
4 changes: 4 additions & 0 deletions dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ BUILD_EXT_FLAGS=""
# Enable CUDA support
if [[ ! -z "${cuda_compiler_version+x}" && "${cuda_compiler_version}" != "None" ]]; then
export PYARROW_WITH_CUDA=1
if [[ "${build_platform}" != "${target_platform}" ]]; then
export CUDAToolkit_ROOT=${CUDA_HOME}
export CMAKE_LIBRARY_PATH=${CONDA_BUILD_SYSROOT}/lib
fi
else
export PYARROW_WITH_CUDA=0
fi
Expand Down
24 changes: 18 additions & 6 deletions dev/tasks/conda-recipes/arrow-cpp/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ outputs:
- libgrpc
- libprotobuf
- libutf8proc
# gandiva requires shared libllvm
- llvm # [unix]
- lz4-c
- nlohmann_json
# gandiva depends on openssl
Expand Down Expand Up @@ -340,13 +342,16 @@ outputs:
- pytest
- pytest-lazy-fixture
- backports.zoneinfo # [py<39]
- boto3
- cffi
- cloudpickle
- cython <3
- fastparquet
- fsspec
- hypothesis
- minio-server
- pandas
- s3fs >=2023
- scipy
# these are generally (far) behind on migrating abseil/grpc/protobuf,
# and using them as test dependencies blocks the migrator unnecessarily
Expand All @@ -361,6 +366,8 @@ outputs:
source_files:
- testing/data
commands:
- cd ${SP_DIR} # [unix]
- cd %SP_DIR% # [win]
- export ARROW_TEST_DATA="${SRC_DIR}/testing/data" # [unix]
- set "ARROW_TEST_DATA=%SRC_DIR%\testing\data" # [win]

Expand All @@ -370,26 +377,31 @@ outputs:
# skip tests that raise SIGINT and crash the test suite
{% set tests_to_skip = tests_to_skip + " or (test_csv and test_cancellation)" %} # [linux]
{% set tests_to_skip = tests_to_skip + " or (test_flight and test_interrupt)" %} # [linux]
# cannot pass -D_LIBCPP_DISABLE_AVAILABILITY to test suite for our older macos sdk
{% set tests_to_skip = tests_to_skip + " or test_cpp_extension_in_python" %} # [osx]
# skip tests that make invalid(-for-conda) assumptions about the compilers setup
{% set tests_to_skip = tests_to_skip + " or test_cython_api" %} # [unix]
{% set tests_to_skip = tests_to_skip + " or test_visit_strings" %} # [unix]
# skip tests that cannot succeed in emulation
{% set tests_to_skip = tests_to_skip + " or test_debug_memory_pool_disabled" %} # [aarch64 or ppc64le]
{% set tests_to_skip = tests_to_skip + " or test_env_var_io_thread_count" %} # [aarch64 or ppc64le]
# XMinioInvalidObjectName on osx/win: "Object name contains unsupported characters"
{% set tests_to_skip = tests_to_skip + " or test_write_to_dataset_with_partitions_s3fs" %} # [osx or win]
# vvvvvvv TESTS THAT SHOULDN'T HAVE TO BE SKIPPED vvvvvvv
# currently broken
{% set tests_to_skip = tests_to_skip + " or test_fastparquet_cross_compatibility" %}
# new fsspec changed behaviour, see https://github.com/apache/arrow/issues/37555
{% set tests_to_skip = tests_to_skip + " or test_get_file_info_with_selector" %}
# segfaults on OSX: to investigate ASAP
{% set tests_to_skip = tests_to_skip + " or test_flight" %} # [osx]
# problems with minio
{% set tests_to_skip = tests_to_skip + " or (test_delete_dir and S3FileSystem)" %}
{% set tests_to_skip = tests_to_skip + " or (test_delete_dir_contents and S3FileSystem)" %}
{% set tests_to_skip = tests_to_skip + " or (test_get_file_info and S3FileSystem)" %}
{% set tests_to_skip = tests_to_skip + " or (test_move_directory and S3FileSystem)" %}
# gandiva tests are segfaulting on ppc
{% set tests_to_skip = tests_to_skip + " or test_gandiva" %} # [ppc64le]
{% set tests_to_skip = tests_to_skip + " or test_gandiva" %} # [ppc64le]
# test failures on ppc (both failing with: Float value was truncated converting to int32)
{% set tests_to_skip = tests_to_skip + " or test_safe_cast_from_float_with_nans_to_int" %} # [ppc64le]
{% set tests_to_skip = tests_to_skip + " or test_float_with_null_as_integer" %} # [ppc64le]
# ^^^^^^^ TESTS THAT SHOULDN'T HAVE TO BE SKIPPED ^^^^^^^
- pytest --pyargs pyarrow -rfEs -k "not ({{ tests_to_skip }})"
- pytest pyarrow/ -rfEs -k "not ({{ tests_to_skip }})"
{% endif %}

about:
Expand Down

0 comments on commit 3584b5d

Please sign in to comment.