GH-35765: [C++] Split vector_selection.cc into more compilation units (…

…#35751) ### Rationale for this change When working on #35001 I had a hard time figuring where to place the code for all possible combinations of filters and REE data. `vector_selection.cc` is hard to follow with so many kernels implemented in a single file. This PR splits the two biggest ones: filter and take. Stuff that can be shared by both stays is in `vector_selection_internal.cc` and `vector_selection.cc` is concerned with the registering of the functions and a few smaller kernels. ### What changes are included in this PR? - [x] `vector_selection_(internal|take|filter).(cc|h)` source files were extracted from `vector_selection.cc` ### Are these changes tested? Yes, by existing tests. * Closes: #35765 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
apache · May 30, 2023 · 44d1b61 · 44d1b61
1 parent 431785f
commit 44d1b61
Show file tree

Hide file tree

Showing 8 changed files with 2,635 additions and 2,186 deletions.
diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
@@ -415,6 +415,9 @@ list(APPEND
      compute/kernels/util_internal.cc
      compute/kernels/vector_hash.cc
      compute/kernels/vector_selection.cc
+     compute/kernels/vector_selection_filter_internal.cc
+     compute/kernels/vector_selection_internal.cc
+     compute/kernels/vector_selection_take_internal.cc
      compute/row/encode_internal.cc
      compute/row/compare_internal.cc
      compute/row/grouper.cc

diff --git a/cpp/src/arrow/compute/kernels/vector_selection.cc b/cpp/src/arrow/compute/kernels/vector_selection.cc