Fix array.setData() to retain before release (#4)

apache · Feb 14, 2020 · 489ca25 · 489ca25
1 parent 88cd05f
commit 489ca25
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/go/arrow/array/array.go b/go/arrow/array/array.go
@@ -119,11 +119,13 @@ func (a *array) IsValid(i int) bool {
 }
 
 func (a *array) setData(data *Data) {
+	// Retain before releasing in case a.data is the same as data.
+	data.Retain()
+
 	if a.data != nil {
 		a.data.Release()
 	}
 
-	data.Retain()
 	if len(data.buffers) > 0 && data.buffers[0] != nil {
 		a.nullBitmapBytes = data.buffers[0].Bytes()
 	}