fix(self-review): s1

apache · Jan 12, 2023 · 64ff7f4 · 64ff7f4
1 parent f2f8937
commit 64ff7f4
Showing 1 changed file with 19 additions and 26 deletions.
diff --git a/cpp/src/arrow/compute/exec/plan_test.cc b/cpp/src/arrow/compute/exec/plan_test.cc
@@ -249,18 +249,15 @@ TEST(ExecPlanExecution, UseSinkAfterExecution) {
 }
 
 TEST(ExecPlanExecution, TableSourceSink) {
-  for (bool parallel : {false, true}) {
-    SCOPED_TRACE(parallel ? "parallel" : "single threaded");
-    for (int batch_size : {1, 4}) {
-      auto exp_batches = MakeBasicBatches();
-      ASSERT_OK_AND_ASSIGN(auto table,
-                           TableFromExecBatches(exp_batches.schema, exp_batches.batches));
-      Declaration plan("table_source", TableSourceNodeOptions{table, batch_size});
-
-      ASSERT_OK_AND_ASSIGN(auto result_table,
-                           DeclarationToTable(std::move(plan), parallel));
-      AssertTablesEqualIgnoringOrder(table, result_table);
-    }
+  for (int batch_size : {1, 4}) {
+    auto exp_batches = MakeBasicBatches();
+    ASSERT_OK_AND_ASSIGN(auto table,
+                         TableFromExecBatches(exp_batches.schema, exp_batches.batches));
+    Declaration plan("table_source", TableSourceNodeOptions{table, batch_size});
+
+    ASSERT_OK_AND_ASSIGN(auto result_table,
+                         DeclarationToTable(std::move(plan), /*use_threads=*/false));
+    AssertTablesEqualIgnoringOrder(table, result_table);
   }
 }
 
@@ -308,20 +305,16 @@ void TestSourceSink(
     std::string source_factory_name,
     std::function<Result<std::vector<ElementType>>(const BatchesWithSchema&)>
         to_elements) {
-  for (bool parallel : {false, true}) {
-    SCOPED_TRACE(parallel ? "parallel" : "single threaded");
-    auto exp_batches = MakeBasicBatches();
-    ASSERT_OK_AND_ASSIGN(auto elements, to_elements(exp_batches));
-    auto element_it_maker = [&elements]() {
-      return MakeVectorIterator<ElementType>(elements);
-    };
-    Declaration plan(source_factory_name,
-                     OptionsType{exp_batches.schema, element_it_maker});
-    ASSERT_OK_AND_ASSIGN(auto result,
-                         DeclarationToExecBatches(std::move(plan), parallel));
-    AssertExecBatchesEqualIgnoringOrder(result.schema, result.batches,
-                                        exp_batches.batches);
-  }
+  auto exp_batches = MakeBasicBatches();
+  ASSERT_OK_AND_ASSIGN(auto elements, to_elements(exp_batches));
+  auto element_it_maker = [&elements]() {
+    return MakeVectorIterator<ElementType>(elements);
+  };
+  Declaration plan(source_factory_name,
+                   OptionsType{exp_batches.schema, element_it_maker});
+  ASSERT_OK_AND_ASSIGN(auto result,
+                       DeclarationToExecBatches(std::move(plan), /*use_threads=*/false));
+  AssertExecBatchesEqualIgnoringOrder(result.schema, result.batches, exp_batches.batches);
 }
 
 TEST(ExecPlanExecution, ArrayVectorSourceSink) {