Skip to content

Commit

Permalink
Attempt to fix linking error on Windows
Browse files Browse the repository at this point in the history
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
  • Loading branch information
dchigarev committed Jan 14, 2021
1 parent c5d3749 commit daf8e07
Show file tree
Hide file tree
Showing 8 changed files with 20 additions and 20 deletions.
10 changes: 5 additions & 5 deletions cpp/src/arrow/array/array_decimal.cc
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ std::string BaseDecimalArray<width>::FormatValue(int64_t i) const {
return value.ToString(type_.scale());
}

template class BaseDecimalArray<16>;
template class BaseDecimalArray<32>;
template class BaseDecimalArray<64>;
template class BaseDecimalArray<128>;
template class BaseDecimalArray<256>;
template class ARROW_EXPORT BaseDecimalArray<16>;
template class ARROW_EXPORT BaseDecimalArray<32>;
template class ARROW_EXPORT BaseDecimalArray<64>;
template class ARROW_EXPORT BaseDecimalArray<128>;
template class ARROW_EXPORT BaseDecimalArray<256>;

} // namespace arrow
2 changes: 1 addition & 1 deletion cpp/src/arrow/array/array_decimal.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ namespace arrow {

/// Template Array class for decimal data
template<uint32_t width>
class BaseDecimalArray : public FixedSizeBinaryArray {
class ARROW_EXPORT BaseDecimalArray : public FixedSizeBinaryArray {
public:
using TypeClass = typename DecimalTypeTraits<width>::TypeClass;
using ValueType = typename DecimalTypeTraits<width>::ValueType;
Expand Down
10 changes: 5 additions & 5 deletions cpp/src/arrow/array/builder_decimal.cc
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ Status BaseDecimalBuilder<width>::FinishInternal(std::shared_ptr<ArrayData>* out
return Status::OK();
}

template class BaseDecimalBuilder<16>;
template class BaseDecimalBuilder<32>;
template class BaseDecimalBuilder<64>;
template class BaseDecimalBuilder<128>;
template class BaseDecimalBuilder<256>;
template class ARROW_EXPORT BaseDecimalBuilder<16>;
template class ARROW_EXPORT BaseDecimalBuilder<32>;
template class ARROW_EXPORT BaseDecimalBuilder<64>;
template class ARROW_EXPORT BaseDecimalBuilder<128>;
template class ARROW_EXPORT BaseDecimalBuilder<256>;

} // namespace arrow
2 changes: 1 addition & 1 deletion cpp/src/arrow/array/builder_decimal.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
namespace arrow {

template<uint32_t width>
class BaseDecimalBuilder : public FixedSizeBinaryBuilder {
class ARROW_EXPORT BaseDecimalBuilder : public FixedSizeBinaryBuilder {
public:
using TypeClass = typename DecimalTypeTraits<width>::TypeClass;
using ArrayType = typename DecimalTypeTraits<width>::ArrayType;
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/type.h
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ class ARROW_EXPORT DecimalType : public FixedSizeBinaryType {

/// \brief Template type class for decimal data
template<uint32_t width>
class BaseDecimalType : public DecimalType {
class ARROW_EXPORT BaseDecimalType : public DecimalType {
public:
static constexpr const char* type_name() { return DecimalMeta<width>::name; }

Expand Down
6 changes: 3 additions & 3 deletions cpp/src/arrow/util/basic_decimal.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1245,8 +1245,8 @@ BasicDecimalAnyWidth<width> BasicDecimalAnyWidth<width>::IncreaseScaleBy(int32_t
return (*this) * ScaleMultipliersAnyWidth<width>::value[increase_by];
}

template class BasicDecimalAnyWidth<64>;
template class BasicDecimalAnyWidth<32>;
template class BasicDecimalAnyWidth<16>;
template class ARROW_EXPORT BasicDecimalAnyWidth<64>;
template class ARROW_EXPORT BasicDecimalAnyWidth<32>;
template class ARROW_EXPORT BasicDecimalAnyWidth<16>;

} // namespace arrow
2 changes: 1 addition & 1 deletion cpp/src/arrow/util/basic_decimal.h
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ ARROW_EXPORT BasicDecimal256 operator/(const BasicDecimal256& left,


template<uint32_t width>
class BasicDecimalAnyWidth {
class ARROW_EXPORT BasicDecimalAnyWidth {
public:
using ValueType = typename IntTypes<width>::signed_type;
/// \brief Empty constructor creates a BasicDecimal256 with a value of 0.
Expand Down
6 changes: 3 additions & 3 deletions cpp/src/arrow/util/decimal.cc
Original file line number Diff line number Diff line change
Expand Up @@ -842,8 +842,8 @@ Status DecimalAnyWidth<width>::ToArrowStatus(DecimalStatus dstatus) const {
return arrow::ToArrowStatus(dstatus, width);
}

template class DecimalAnyWidth<16>;
template class DecimalAnyWidth<32>;
template class DecimalAnyWidth<64>;
template class ARROW_EXPORT DecimalAnyWidth<16>;
template class ARROW_EXPORT DecimalAnyWidth<32>;
template class ARROW_EXPORT DecimalAnyWidth<64>;

} // namespace arrow

0 comments on commit daf8e07

Please sign in to comment.