added mmap argument to all methods of feather_table_reader

apache · Nov 14, 2018 · e92552f · e92552f
1 parent ab357ae
commit e92552f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/r/R/feather.R b/r/R/feather.R
@@ -117,12 +117,12 @@ write_feather_RecordBatch <- function(data, stream) {
 #' @param ... extra parameters
 #'
 #' @export
-feather_table_reader <- function(file, ...){
+feather_table_reader <- function(file, mmap = TRUE, ...){
   UseMethod("feather_table_reader")
 }
 
 #' @export
-feather_table_reader.default <- function(file, ...) {
+feather_table_reader.default <- function(file, mmap = TRUE, ...) {
   stop("unsupported")
 }
 
@@ -138,12 +138,12 @@ feather_table_reader.fs_path <- function(file, mmap = TRUE, ...) {
 }
 
 #' @export
-`feather_table_reader.arrow::io::RandomAccessFile` <- function(file, ...){
+`feather_table_reader.arrow::io::RandomAccessFile` <- function(file, mmap = TRUE, ...){
   unique_ptr(`arrow::ipc::feather::TableReader`, ipc___feather___TableReader__Open(file))
 }
 
 #' @export
-`feather_table_reader.arrow::ipc::feather::TableReader` <- function(file){
+`feather_table_reader.arrow::ipc::feather::TableReader` <- function(file, mmap = TRUE, ...){
   file
 }
 

diff --git a/r/man/feather_table_reader.Rd b/r/man/feather_table_reader.Rd