Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Compute] Optimize IfElse kernel AAS/ASA case when the scalar is null #15290

Closed
js8544 opened this issue Jan 10, 2023 · 0 comments · Fixed by #15291
Closed

[C++][Compute] Optimize IfElse kernel AAS/ASA case when the scalar is null #15290

js8544 opened this issue Jan 10, 2023 · 0 comments · Fixed by #15291
Assignees
@js8544
Labels
Component: C++ Type: enhancement
Milestone
11.0.0

Comments

@js8544
Copy link
Collaborator

js8544 commented Jan 10, 2023

Describe the enhancement requested

In AAS and ASA case, when the scalar is null, we only need to construct a new validity bitmap and copy the input array data to output. We can skip looping over the input array.

Component(s)

C++
js8544 added a commit to js8544/arrow that referenced this issue Jan 10, 2023
@js8544
apacheGH-15290: [C++][Compute] Optimize IfElse kernel AAS/ASA case wh…
e965e1a 
…en the scalar is null
@js8544 js8544 mentioned this issue Jan 10, 2023
Merged
js8544 added a commit to js8544/arrow that referenced this issue Jan 10, 2023
@js8544
apacheGH-15290: [C++][Compute] Optimize IfElse kernel AAS/ASA case wh…
5032fca 
…en the scalar is null
lidavidm pushed a commit that referenced this issue Jan 12, 2023
@js8544
GH-15290: [C++][Compute] Optimize IfElse kernel AAS/ASA case when the…
37a7965 
… scalar is null (#15291)

# Which issue does this PR close?

<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how 
to contribute here:
  * [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
  * [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)


If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

    GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

    MINOR: [${COMPONENT}] ${SUMMARY}

In the case of old issues on JIRA the title also supports:

    ARROW-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
    PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

-->
Closes #15290

# Rationale for this change

<!--
 Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
 Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
-->

In AAS and ASA case, when the scalar is null, we only need to construct a new validity bitmap and copy the input array data to output. We can skip looping over the input array.

# What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->

The above optimization for numeric and binary arrays. 

# Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->

Tested with the original IfElse tests.

# Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `breaking-change` label.
-->

No.
* Closes: #15290

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 11.0.0 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@js8544 js8544

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-15290: [C++][Compute] Optimize IfElse kernel AAS/ASA case when the scalar is null js8544/arrow
2 participants
@lidavidm @js8544