Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Parquet] Improve bounds checking on some inputs #20488

Closed
asfimport opened this issue Nov 5, 2022 · 1 comment
Closed

[C++][Parquet] Improve bounds checking on some inputs #20488

asfimport opened this issue Nov 5, 2022 · 1 comment

Comments

@asfimport
Copy link
Collaborator

In some cases we don't check for lower bound of 0, on some non-performance critical paths we only have DCHECKs, and while unlikely in some cases we cast from size_t to int32 which can overflow, adding some safety checks here would be useful.

Reporter: Micah Kornfield / @emkornfield
Assignee: Micah Kornfield / @emkornfield

PRs and other links:

Note: This issue was originally created as ARROW-18253. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 14592
#14592

@asfimport asfimport added this to the 11.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants