ARROW-18253: [C++][Parquet] Add additional bounds safety checks

[emkornfield]

No description provided.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-18253

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[pitrou]

Is this something that can happen due to bad user input? Or are you simply checking for internal invariants?

[emkornfield]

Is this something that can happen due to bad user input? Or are you simply checking for internal invariants?

A little bit of both. The only one as far as I can determine that would be a function of bad parquet files is the overflow when down-casting. But I think there are other safe guard in place here. In terms of bad user input, if we are talking about code that consumes these libraries I think most of the places do the negative checks are guards against here (the one exception being PathWriter), which I believe is completely internal. These were raised by another team doing a code audit and "yellow flags". If any of them strike you as superfluous I can revert them.

[ursabot]

Benchmark runs are scheduled for baseline = 28a1152 and contender = 147b5c9. 147b5c9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.3% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.14% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 147b5c92 ec2-t3-xlarge-us-east-2
[Finished] 147b5c92 test-mac-arm
[Finished] 147b5c92 ursa-i9-9960x
[Finished] 147b5c92 ursa-thinkcentre-m75q
[Finished] 28a1152a ec2-t3-xlarge-us-east-2
[Finished] 28a1152a test-mac-arm
[Finished] 28a1152a ursa-i9-9960x
[Finished] 28a1152a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java