Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Remove support for triggering GitHub Actions apache/arrow-site website deployment workflow when pushing to master #31412

Closed
Tracked by #31142
asfimport opened this issue Mar 21, 2022 · 7 comments · Fixed by apache/arrow-site#323

Comments

@asfimport
Copy link
Collaborator

This is a follow up to ARROW-15694.

Once Apache Infra switches the default Git branch from master to main in apache/arrow-site, we should completely remove support for triggering the deploy.yml CI workflow on a push to master.

This should be straightforward and would involve removing master from the .github/workflows/deploy.yml push trigger condition.

Reporter: Kevin Gurney / @kevingurney

Note: This issue was originally created as ARROW-15988. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Todd Farmer / @toddfarmer:
This issue was last updated over 90 days ago, which may be an indication it is no longer being actively worked. To better reflect the current state, the issue is being unassigned. Please feel free to re-take assignment of the issue if it is being actively worked, or if you plan to start that work soon.

@kevingurney
Copy link
Member

take

@kevingurney
Copy link
Member

I verified that the apache/arrow-site deployment workflows in .github/workflows/deploy.yml are already prepared to work with "main" or "master".

See line 23 and line 51.

Note that the Jira issue ARROW-15988, which is referred to in the comments on these lines, is now being tracked as #31412 (this issue) in GitHub Issues. However, this issue can't be addressed until the default branch has been renamed to "main". Therefore, I'll follow up with a PR to address this as soon as Apache INFRA has renamed the default branch of the apache/arrow-site repo to "main".

@jorisvandenbossche
Copy link
Member

The master->main branch rename is now also done for the apache/arrow-site repo, so you can go forward with this

@kevingurney
Copy link
Member

Thanks, @jorisvandenbossche. I'll proceed with the changes.

@kevingurney
Copy link
Member

I don't think I have the permissions to change it, but I think this issue should be part of the [Website] component rather than the [Dev] component.

@kou kou changed the title [Dev] Remove support for triggering GitHub Actions apache/arrow-site website deployment workflow when pushing to master [Website] Remove support for triggering GitHub Actions apache/arrow-site website deployment workflow when pushing to master Mar 1, 2023
@kou
Copy link
Member

kou commented Mar 1, 2023

Changed the component.

kou pushed a commit to apache/arrow-site that referenced this issue Mar 1, 2023
…he/arrow-site website deployment workflow when pushing to master (#323)

# Overview

As part of apache/arrow#31142 and in response to the [recent rename of
the `apache/arrow-site` repository default branch to
`main`](https://issues.apache.org/jira/browse/INFRA-24242), this pull
request removes support for triggering the website deployment workflow
(`.github/workflows/deploy.yml`) on pushes to a branch with the name
"master".

# Qualification

To qualify these changes, I verified that:

1. Pushing these changes to the `main` branch of `mathworks/arrow-site`
[triggered the `deploy.yml` workflow as
expected](https://github.com/mathworks/arrow-site/actions/runs/4296490412/jobs/7488276762).
2. The workflow step "Configure for GitHub Pages on push to main or
master branch" has been renamed to "Configure for GitHub Pages on push
to main branch"
3. The `deploy.yml` is no longer being triggered when commits are pushed
to a branch named "master".

# Future Directions

1. I will follow up with a separate PR to address apache/arrow#20161

# Notes

**Note**: The [CI failures in the Build
step](https://github.com/mathworks/arrow-site/actions/runs/4296490412/jobs/7488276762)
are unrelated to this change. This is a result of apache/arrow#34379,
which is being addressed separately.

Closes apache/arrow#31412.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment