-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Website] Remove support for triggering GitHub Actions apache/arrow-site website deployment workflow when pushing to master #31412
Comments
Todd Farmer / @toddfarmer: |
take |
I verified that the Note that the Jira issue |
The master->main branch rename is now also done for the apache/arrow-site repo, so you can go forward with this |
Thanks, @jorisvandenbossche. I'll proceed with the changes. |
I don't think I have the permissions to change it, but I think this issue should be part of the |
Changed the component. |
…he/arrow-site website deployment workflow when pushing to master (#323) # Overview As part of apache/arrow#31142 and in response to the [recent rename of the `apache/arrow-site` repository default branch to `main`](https://issues.apache.org/jira/browse/INFRA-24242), this pull request removes support for triggering the website deployment workflow (`.github/workflows/deploy.yml`) on pushes to a branch with the name "master". # Qualification To qualify these changes, I verified that: 1. Pushing these changes to the `main` branch of `mathworks/arrow-site` [triggered the `deploy.yml` workflow as expected](https://github.com/mathworks/arrow-site/actions/runs/4296490412/jobs/7488276762). 2. The workflow step "Configure for GitHub Pages on push to main or master branch" has been renamed to "Configure for GitHub Pages on push to main branch" 3. The `deploy.yml` is no longer being triggered when commits are pushed to a branch named "master". # Future Directions 1. I will follow up with a separate PR to address apache/arrow#20161 # Notes **Note**: The [CI failures in the Build step](https://github.com/mathworks/arrow-site/actions/runs/4296490412/jobs/7488276762) are unrelated to this change. This is a result of apache/arrow#34379, which is being addressed separately. Closes apache/arrow#31412.
This is a follow up to ARROW-15694.
Once Apache Infra switches the default Git branch from master to main in apache/arrow-site, we should completely remove support for triggering the deploy.yml CI workflow on a push to master.
This should be straightforward and would involve removing master from the
.github/workflows/deploy.yml
push trigger condition.Reporter: Kevin Gurney / @kevingurney
Note: This issue was originally created as ARROW-15988. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: