Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java][FlightRPC] Add options to JDBC to reuse credentials and cookies in getStream sub-clients #38576

Closed
jduo opened this issue Nov 3, 2023 · 1 comment · Fixed by #38580
Closed

[Java][FlightRPC] Add options to JDBC to reuse credentials and cookies in getStream sub-clients #38576

jduo opened this issue Nov 3, 2023 · 1 comment · Fixed by #38580
Assignees
@jduo
Labels
Component: FlightRPC Component: Java Type: enhancement
Milestone
15.0.0

Comments

@jduo
Copy link
Member

jduo commented Nov 3, 2023

Describe the enhancement requested

In #38521 , the driver was changed to spawn entirely new connections when connecting to endpoints reported by GetFlightInfo for getStream() calls.

The previous behavior would be to use the same connection including all cookies and credentials. While it was not correct to use the same physical connection since the endpoints can differ, it may be valid to reuse the same cookies and credentials.

Component(s)

FlightRPC, Java
@jduo jduo mentioned this issue Nov 3, 2023
Merged
@jduo
Copy link
Member Author

jduo commented Nov 3, 2023

take

@aiguofer aiguofer mentioned this issue Nov 3, 2023
Closed
jduo added a commit to Bit-Quill/arrow that referenced this issue Nov 3, 2023
@jduo
apacheGH-38576: [Java] Change JDBC driver to optionally preserve cook…
f70b268 
…ies and auth tokens when getting streams

- Change the JDBC driver to add new properties "retainCookies" and "retainAuth"
- These properties allow internally spawned connections for getting streams to
use the cookies and bearer tokens from the original connection.
- Add tests for validating defaults from ArrowFlightSqlClient.Builder
@github-actions github-actions bot mentioned this issue Nov 3, 2023
Merged
jduo added a commit to Bit-Quill/arrow that referenced this issue Nov 5, 2023
@jduo
apacheGH-38576: [Java] Change JDBC driver to optionally preserve cook…
539e622 
…ies and auth tokens when getting streams

- Change the JDBC driver to add new properties "retainCookies" and "retainAuth"
- These properties allow internally spawned connections for getting streams to
use the cookies and bearer tokens from the original connection.
- Add tests for validating defaults from ArrowFlightSqlClient.Builder
jduo added a commit to Bit-Quill/arrow that referenced this issue Nov 6, 2023
@jduo
apacheGH-38576: [Java] Change JDBC driver to optionally preserve cook…
1b143a1 
…ies and auth tokens when getting streams

- Change the JDBC driver to add new properties "retainCookies" and "retainAuth"
- These properties allow internally spawned connections for getting streams to
use the cookies and bearer tokens from the original connection.
- Add tests for validating defaults from ArrowFlightSqlClient.Builder
jduo added a commit to Bit-Quill/arrow that referenced this issue Nov 6, 2023
@jduo
apacheGH-38576: [Java] Change JDBC driver to optionally preserve cook…
c23d4be 
…ies and auth tokens when getting streams

- Change the JDBC driver to add new properties "retainCookies" and "retainAuth"
- These properties allow internally spawned connections for getting streams to
use the cookies and bearer tokens from the original connection.
- Add tests for validating defaults from ArrowFlightSqlClient.Builder
jduo added a commit to Bit-Quill/arrow that referenced this issue Nov 6, 2023
@jduo
apacheGH-38576: [Java] Change JDBC driver to optionally preserve cook…
a6b041a 
…ies and auth tokens when getting streams

- Change the JDBC driver to add new properties "retainCookies" and "retainAuth"
- These properties allow internally spawned connections for getting streams to
use the cookies and bearer tokens from the original connection.
- Add tests for validating defaults from ArrowFlightSqlClient.Builder
jduo added a commit to Bit-Quill/arrow that referenced this issue Nov 6, 2023
@jduo
apacheGH-38576: [Java] Change JDBC driver to optionally preserve cook…
67d5fee 
…ies and auth tokens when getting streams

- Change the JDBC driver to add new properties "retainCookies" and "retainAuth"
- These properties allow internally spawned connections for getting streams to
use the cookies and bearer tokens from the original connection.
- Add tests for validating defaults from ArrowFlightSqlClient.Builder
@lidavidm lidavidm added this to the 15.0.0 milestone Nov 7, 2023
lidavidm pushed a commit that referenced this issue Nov 7, 2023
@jduo
GH-38576: [Java] Change JDBC driver to optionally preserve cookies an…
fafd48c 
…d auth tokens when getting streams (#38580)

### Rationale for this change
This change restores the original behavior of transmitting existing cookies and auth tokens when getting separate
streams returned by getFlightInfo after adding support for multiple endpoints.

These properties are now optional though.

### What changes are included in this PR?
- Change the JDBC driver to add new properties "retainCookies" and "retainAuth"
- These properties allow internally spawned connections for getting streams to use the cookies and bearer tokens from the original connection.
- Add tests for validating defaults from ArrowFlightSqlClient.Builder

### Are these changes tested?
Unit tests have been added.

### Are there any user-facing changes?
Yes. There are now properties and they are documented.
* Closes: #38576

Authored-by: James Duong <james.duong@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Nov 9, 2023
@jduo @JerAguilon
apacheGH-38576: [Java] Change JDBC driver to optionally preserve cook…
753a9aa 
…ies and auth tokens when getting streams (apache#38580)

### Rationale for this change
This change restores the original behavior of transmitting existing cookies and auth tokens when getting separate
streams returned by getFlightInfo after adding support for multiple endpoints.

These properties are now optional though.

### What changes are included in this PR?
- Change the JDBC driver to add new properties "retainCookies" and "retainAuth"
- These properties allow internally spawned connections for getting streams to use the cookies and bearer tokens from the original connection.
- Add tests for validating defaults from ArrowFlightSqlClient.Builder

### Are these changes tested?
Unit tests have been added.

### Are there any user-facing changes?
Yes. There are now properties and they are documented.
* Closes: apache#38576

Authored-by: James Duong <james.duong@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@jduo @loicalleyne
apacheGH-38576: [Java] Change JDBC driver to optionally preserve cook…
15924c6 
…ies and auth tokens when getting streams (apache#38580)

### Rationale for this change
This change restores the original behavior of transmitting existing cookies and auth tokens when getting separate
streams returned by getFlightInfo after adding support for multiple endpoints.

These properties are now optional though.

### What changes are included in this PR?
- Change the JDBC driver to add new properties "retainCookies" and "retainAuth"
- These properties allow internally spawned connections for getting streams to use the cookies and bearer tokens from the original connection.
- Add tests for validating defaults from ArrowFlightSqlClient.Builder

### Are these changes tested?
Unit tests have been added.

### Are there any user-facing changes?
Yes. There are now properties and they are documented.
* Closes: apache#38576

Authored-by: James Duong <james.duong@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@jduo @dgreiss
apacheGH-38576: [Java] Change JDBC driver to optionally preserve cook…
b4bee2e 
…ies and auth tokens when getting streams (apache#38580)

### Rationale for this change
This change restores the original behavior of transmitting existing cookies and auth tokens when getting separate
streams returned by getFlightInfo after adding support for multiple endpoints.

These properties are now optional though.

### What changes are included in this PR?
- Change the JDBC driver to add new properties "retainCookies" and "retainAuth"
- These properties allow internally spawned connections for getting streams to use the cookies and bearer tokens from the original connection.
- Add tests for validating defaults from ArrowFlightSqlClient.Builder

### Are these changes tested?
Unit tests have been added.

### Are there any user-facing changes?
Yes. There are now properties and they are documented.
* Closes: apache#38576

Authored-by: James Duong <james.duong@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jduo jduo

Labels
Component: FlightRPC Component: Java Type: enhancement
Projects
None yet
Milestone
15.0.0
2 participants
@lidavidm @jduo