Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Implement Holder-based functions in ViewVarBinaryVector #40936

Closed
Tracked by #40340
vibhatha opened this issue Apr 2, 2024 · 2 comments
Closed
Tracked by #40340

[Java] Implement Holder-based functions in ViewVarBinaryVector #40936

vibhatha opened this issue Apr 2, 2024 · 2 comments
Assignees
@vibhatha
Labels
Component: Java Type: enhancement
Milestone
18.0.0

Comments

@vibhatha
Copy link
Collaborator

vibhatha commented Apr 2, 2024

Describe the enhancement requested

At the moment in the StringView implementation, holders are not supported. The NullableViewVarBinaryHolder and ViewVarBinaryHolder must be implemented.

Component(s)

Java
@vibhatha vibhatha mentioned this issue Apr 2, 2024
Merged
14 tasks
lidavidm pushed a commit that referenced this issue Apr 29, 2024
@vibhatha
GH-40339: [Java] StringView Initial Implementation (#40340)
a8c4f86 
### Rationale for this change 

StringView implementation in Java. This PR only includes the core implementation of StringView

### What changes are included in this PR?

- [X] Adding ViewVarBinaryVector
- [X] Adding ViewVarCharVector
- [X] Adding corresponding test cases in the given scope
- [X] Including required implementation extensions with not supported warnings
- [X] Interface for Holders

### Non Goals of this PR

- [ ] #40937
- [ ] #40936
- [ ] #40932
- [ ] #40943
- [ ] #40944
- [ ] #40942
- [ ] https://github.com/apache/arrow/issues/40945
- [ ] https://github.com/apache/arrow/issues/40941
- [ ] https://github.com/apache/arrow/issues/40946

### Are these changes tested?

Yes. Existing test cases on `VarCharVector` and `VarBinaryVector` are verified with view implementations and additional test cases have also been added to check view functionality. And explitly tests have been added to evaluate the view functionality with `ViewVarCharVector`

### Are there any user-facing changes?

Yes, this introduces a new API and some public methods have been included in an interface so that it can be extended to write custom functionality like done for views. 

* GitHub Issue: #40339

Lead-authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Co-authored-by: vibhatha <vibhatha@gmail.com>
Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@vibhatha vibhatha self-assigned this Apr 29, 2024
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@vibhatha @tolleybot
apacheGH-40339: [Java] StringView Initial Implementation (apache#40340)
5b555ef 
### Rationale for this change 

StringView implementation in Java. This PR only includes the core implementation of StringView

### What changes are included in this PR?

- [X] Adding ViewVarBinaryVector
- [X] Adding ViewVarCharVector
- [X] Adding corresponding test cases in the given scope
- [X] Including required implementation extensions with not supported warnings
- [X] Interface for Holders

### Non Goals of this PR

- [ ] apache#40937
- [ ] apache#40936
- [ ] apache#40932
- [ ] apache#40943
- [ ] apache#40944
- [ ] apache#40942
- [ ] https://github.com/apache/arrow/issues/40945
- [ ] https://github.com/apache/arrow/issues/40941
- [ ] https://github.com/apache/arrow/issues/40946

### Are these changes tested?

Yes. Existing test cases on `VarCharVector` and `VarBinaryVector` are verified with view implementations and additional test cases have also been added to check view functionality. And explitly tests have been added to evaluate the view functionality with `ViewVarCharVector`

### Are there any user-facing changes?

Yes, this introduces a new API and some public methods have been included in an interface so that it can be extended to write custom functionality like done for views. 

* GitHub Issue: apache#40339

Lead-authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Co-authored-by: vibhatha <vibhatha@gmail.com>
Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
vibhatha added a commit to vibhatha/arrow that referenced this issue May 25, 2024
@vibhatha
apacheGH-40339: [Java] StringView Initial Implementation (apache#40340)
aacd821 
### Rationale for this change 

StringView implementation in Java. This PR only includes the core implementation of StringView

### What changes are included in this PR?

- [X] Adding ViewVarBinaryVector
- [X] Adding ViewVarCharVector
- [X] Adding corresponding test cases in the given scope
- [X] Including required implementation extensions with not supported warnings
- [X] Interface for Holders

### Non Goals of this PR

- [ ] apache#40937
- [ ] apache#40936
- [ ] apache#40932
- [ ] apache#40943
- [ ] apache#40944
- [ ] apache#40942
- [ ] https://github.com/apache/arrow/issues/40945
- [ ] https://github.com/apache/arrow/issues/40941
- [ ] https://github.com/apache/arrow/issues/40946

### Are these changes tested?

Yes. Existing test cases on `VarCharVector` and `VarBinaryVector` are verified with view implementations and additional test cases have also been added to check view functionality. And explitly tests have been added to evaluate the view functionality with `ViewVarCharVector`

### Are there any user-facing changes?

Yes, this introduces a new API and some public methods have been included in an interface so that it can be extended to write custom functionality like done for views. 

* GitHub Issue: apache#40339

Lead-authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Co-authored-by: vibhatha <vibhatha@gmail.com>
Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@ViggoC ViggoC mentioned this issue Sep 25, 2024
Merged
lidavidm pushed a commit that referenced this issue Sep 26, 2024
@ViggoC
GH-40937: [Java] Implement Holder-based functions for ViewVarCharVect…
bc923bd 
…or & ViewVarBinaryVector (#44187)

* GitHub Issue: #40936
* GitHub Issue: #40937

Authored-by: chenweiguo.vc <chenweiguo.vc@bytedance.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@ViggoC
Copy link
Contributor

ViggoC commented Sep 26, 2024

@lidavidm This issue can be closed too.

@vibhatha
Copy link
Collaborator Author

Issue resolved by #44187

@lidavidm lidavidm added this to the 18.0.0 milestone Sep 26, 2024
kou pushed a commit to apache/arrow-java that referenced this issue Nov 25, 2024
@vibhatha @kou
GH-40339: [Java] StringView Initial Implementation (#40340)
3d76fb0 
### Rationale for this change 

StringView implementation in Java. This PR only includes the core implementation of StringView

### What changes are included in this PR?

- [X] Adding ViewVarBinaryVector
- [X] Adding ViewVarCharVector
- [X] Adding corresponding test cases in the given scope
- [X] Including required implementation extensions with not supported warnings
- [X] Interface for Holders

### Non Goals of this PR

- [ ] apache/arrow#40937
- [ ] apache/arrow#40936
- [ ] apache/arrow#40932
- [ ] apache/arrow#40943
- [ ] apache/arrow#40944
- [ ] apache/arrow#40942
- [ ] https://github.com/apache/arrow/issues/40945
- [ ] https://github.com/apache/arrow/issues/40941
- [ ] https://github.com/apache/arrow/issues/40946

### Are these changes tested?

Yes. Existing test cases on `VarCharVector` and `VarBinaryVector` are verified with view implementations and additional test cases have also been added to check view functionality. And explitly tests have been added to evaluate the view functionality with `ViewVarCharVector`

### Are there any user-facing changes?

Yes, this introduces a new API and some public methods have been included in an interface so that it can be extended to write custom functionality like done for views. 

* GitHub Issue: #40339

Lead-authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Co-authored-by: vibhatha <vibhatha@gmail.com>
Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vibhatha vibhatha

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
3 participants
@lidavidm @vibhatha @ViggoC