Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Add a benchmark for grouper for preventing performance regression #41035

Closed
ZhangHuiGui opened this issue Apr 5, 2024 · 1 comment
Closed

[C++] Add a benchmark for grouper for preventing performance regression #41035

ZhangHuiGui opened this issue Apr 5, 2024 · 1 comment
Assignees
@ZhangHuiGui
Labels
Component: C++ Type: enhancement
Milestone
17.0.0

Comments

@ZhangHuiGui
Copy link
Collaborator

Describe the enhancement requested

Enhancement comes from the #40998 (comment).

We find it's a big performance improvement for grouper to resort columns in rowtable:

arrow/cpp/src/arrow/compute/row/row_internal.cc

Lines 87 to 88 in 83359d6

std::sort(
column_order.begin(), column_order.end(), [&cols](uint32_t left, uint32_t right) {

In order to prevent performance regression, we should add a benchmark for grouper.

Component(s)

C++
@github-actions github-actions bot mentioned this issue Apr 5, 2024
Merged
pitrou pushed a commit that referenced this issue May 21, 2024
@ZhangHuiGui
GH-41035: [C++] Add a grouper benchmark for preventing performance re…
28ab4af 
…gression (#41036)

### Rationale for this change
Add a grouper benchmark for preventing performance regression . 

#40998 (comment).

### What changes are included in this PR?
Added a benchmark.

### Are these changes tested?
Needn't.

### Are there any user-facing changes?
No

* GitHub Issue: #41035

Authored-by: ZhangHuiGui <hugo.zhang@openpie.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 17.0.0 milestone May 21, 2024
@pitrou
Copy link
Member

pitrou commented May 21, 2024

Issue resolved by pull request 41036
#41036

@pitrou pitrou closed this as completed May 21, 2024
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@ZhangHuiGui @vibhatha
apacheGH-41035: [C++] Add a grouper benchmark for preventing performa…
d6233ea 
…nce regression (apache#41036)

### Rationale for this change
Add a grouper benchmark for preventing performance regression . 

apache#40998 (comment).

### What changes are included in this PR?
Added a benchmark.

### Are these changes tested?
Needn't.

### Are there any user-facing changes?
No

* GitHub Issue: apache#41035

Authored-by: ZhangHuiGui <hugo.zhang@openpie.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZhangHuiGui ZhangHuiGui

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@pitrou @ZhangHuiGui