Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FS][Azure] Implement PathFromUri support #43097

Closed
OliLay opened this issue Jul 1, 2024 · 1 comment
Closed

[C++][FS][Azure] Implement PathFromUri support #43097

OliLay opened this issue Jul 1, 2024 · 1 comment
Assignees
@OliLay
Labels
Component: C++ Type: enhancement
Milestone
18.0.0

Comments

@OliLay
Copy link
Contributor

OliLay commented Jul 1, 2024

Describe the enhancement requested

Other filesystems, such as e.g. S3, implement the virtual PathFromUri method. For the respective S3 implementation, see here.
For the Azure file system, this method is currently not implemented while it certainly should be to comply with the file system API.

Component(s)

C++
@OliLay OliLay mentioned this issue Jul 1, 2024
Merged
kou pushed a commit that referenced this issue Aug 14, 2024
@OliLay
GH-43097: [C++] Implement PathFromUri support for Azure file system (…
88e8140 
…#43098)

### Rationale for this change

See #43097.

### What changes are included in this PR?
Implements `AzureFS::PathFromUri` using existing URI parsing and path extraction inside the `AzureOptions`.

### Are these changes tested?
Yes, added a unit test.

### Are there any user-facing changes?
No, but calling `PathFromUri` will now work instead of throwing due to no implementation provided.
* GitHub Issue: #43097

Authored-by: Oliver Layer <o.layer@celonis.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 18.0.0 milestone Aug 14, 2024
@kou
Copy link
Member

kou commented Aug 14, 2024

Issue resolved by pull request 43098
#43098

@kou kou closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OliLay OliLay

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@kou @OliLay