Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet][CI] Seed corpus should also use bad data files #43703

Closed
pitrou opened this issue Aug 15, 2024 · 3 comments
Closed

[C++][Parquet][CI] Seed corpus should also use bad data files #43703

pitrou opened this issue Aug 15, 2024 · 3 comments
Assignees
@mapleFU
Labels
Component: C++ Component: Continuous Integration Component: Parquet Type: enhancement
Milestone
18.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Aug 15, 2024

Describe the enhancement requested

Currently our Parquet fuzzing seed corpus consists entirely of testing data files, see here:

arrow/cpp/build-support/fuzzing/generate_corpuses.sh

Lines 57 to 58 in ab432b1

# Add Parquet testing examples
cp ${ARROW_CPP}/submodules/parquet-testing/data/*.parquet ${CORPUS_DIR}

We should also add files from the bad_data directory in the testing repository.

Component(s)

C++, Continuous Integration, Parquet
@pitrou
Copy link
Member Author

pitrou commented Aug 15, 2024

@mapleFU Would you like to take a look?

@mapleFU
Copy link
Member

mapleFU commented Aug 15, 2024

I'd like adding this tonight when I back home

@github-actions github-actions bot mentioned this issue Aug 15, 2024
Merged
pitrou pushed a commit that referenced this issue Aug 15, 2024
@mapleFU
GH-43703: [C++][Parquet][CI] Parquet: Introducing more bad_data for t…
fb202ee 
…esting (#43708)

### Rationale for this change

Introducing more bad_data for testing

### What changes are included in this PR?

* Upgrade parquet-testing
* Introduce more bad_data
* Update fuzz generation

### Are these changes tested?

They're tests :-)

### Are there any user-facing changes?

no

* GitHub Issue: #43703

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 18.0.0 milestone Aug 15, 2024
@pitrou
Copy link
Member Author

pitrou commented Aug 15, 2024

Issue resolved by pull request 43708
#43708

@pitrou pitrou closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Component: Continuous Integration Component: Parquet Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@pitrou @mapleFU