Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Remove Python version guard when installing GCS testbench #43883

Closed
pitrou opened this issue Aug 29, 2024 · 1 comment
Closed

[CI] Remove Python version guard when installing GCS testbench #43883

pitrou opened this issue Aug 29, 2024 · 1 comment
Assignees
@pitrou
Labels
Component: Continuous Integration Type: enhancement
Milestone
18.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Aug 29, 2024

Describe the enhancement requested

This condition should be obsolete now that PR #43852 has been merged:

arrow/ci/scripts/install_gcs_testbench.sh

Line 49 in 58415d1

if [[ -z "${PYTHON_VERSION}" ]] || [[ "${PYTHON_VERSION}" != "3.13" ]]; then

Component(s)

Continuous Integration
@pitrou pitrou mentioned this issue Aug 29, 2024
Merged
pitrou added a commit to pitrou/arrow that referenced this issue Aug 29, 2024
@pitrou
apacheGH-43883: [CI] Remove Python version guard when installing GCS …
22af355 
…testbench
@github-actions github-actions bot mentioned this issue Aug 29, 2024
Merged
pitrou added a commit to pitrou/arrow that referenced this issue Sep 2, 2024
@pitrou
apacheGH-43883: [CI] Remove Python version guard when installing GCS …
4a5af8e 
…testbench
pitrou added a commit that referenced this issue Sep 2, 2024
@pitrou
GH-43883: [CI] Remove Python version guard when installing GCS testbe…
7d4cf37 
…nch (#43884)

We can now use the GCS testbench even if we are testing a Python version that does not support it.

* GitHub Issue: #43883

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 18.0.0 milestone Sep 2, 2024
@pitrou
Copy link
Member Author

pitrou commented Sep 2, 2024

Issue resolved by pull request 43884
#43884

@pitrou pitrou closed this as completed Sep 2, 2024
mapleFU pushed a commit to mapleFU/arrow that referenced this issue Sep 3, 2024
@pitrou @mapleFU
apacheGH-43883: [CI] Remove Python version guard when installing GCS …
05976aa 
…testbench (apache#43884)

We can now use the GCS testbench even if we are testing a Python version that does not support it.

* GitHub Issue: apache#43883

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Sep 6, 2024
@pitrou @zanmato1984
apacheGH-43883: [CI] Remove Python version guard when installing GCS …
e15cc70 
…testbench (apache#43884)

We can now use the GCS testbench even if we are testing a Python version that does not support it.

* GitHub Issue: apache#43883

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
@pitrou @khwilson
apacheGH-43883: [CI] Remove Python version guard when installing GCS …
7ed01ee 
…testbench (apache#43884)

We can now use the GCS testbench even if we are testing a Python version that does not support it.

* GitHub Issue: apache#43883

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: Continuous Integration Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
1 participant
@pitrou