Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put license file at module root #7351

Closed
jba opened this issue Jun 4, 2020 · 3 comments
Closed

put license file at module root #7351

jba opened this issue Jun 4, 2020 · 3 comments

Comments

@jba
Copy link

jba commented Jun 4, 2020

The Go package discovery service, https://pkg.go.dev, looks for a redistributable license at the root of a module to determine whether it can display the README and documentation for the module.

Although there is an acceptable license file at the repo root, there isn't one at the module root, in the go/arrow directory.

Please copy the LICENSE.txt file from the repo root to the go/arrow directory.

@wesm
Copy link
Member

wesm commented Jun 4, 2020

Would a symlink work?

@jba
Copy link
Author

jba commented Jun 5, 2020

It doesn't work at present. I filed the issue linked above.

Whatever the resolution of that issue, nothing will happen soon (Go is just beginning a 6-month release cycle), so maybe you could copy temporarily.

@jba
Copy link
Author

jba commented Jun 5, 2020

golang/go#39417 was closed with an explanation of why symlinks can never happen. It suggests one alternative to making the copy, which is renaming the file at root to LICENSE.

kszucs pushed a commit that referenced this issue Jun 5, 2020
See #7351. Once `go mod` can follow symlinks this should be replaced by a symlink.

Closes #7355 from wesm/go-license-file

Authored-by: Wes McKinney <wesm@apache.org>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants