Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-13493 [C++] Anonymous structs in an anonymous union are a GNU extension #10833

Closed
wants to merge 2 commits into from
Closed

ARROW-13493 [C++] Anonymous structs in an anonymous union are a GNU extension #10833

wants to merge 2 commits into from

Conversation

nirandaperera
Copy link
Contributor

No description provided.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-13493

@nealrichardson
Copy link
Member

I've reproduced the error on #10839, so I'll merge that (assuming I haven't broken other things) and then you can rebase this, run the as-cran crossbow job, and we should see the build pass.

@nealrichardson
Copy link
Member

ok @nirandaperera, merged, please rebase and then do @github-actions crossbow submit test-r-linux-as-cran

@nirandaperera
Copy link
Contributor Author

@github-actions crossbow submit test-r-linux-as-cran

@github-actions
Copy link

Revision: fe0b1ec

Submitted crossbow builds: ursacomputing/crossbow @ actions-678

Task Status
test-r-linux-as-cran Github Actions

@nealrichardson
Copy link
Member

Looks like you fixed one warning but there's still another: https://github.com/ursacomputing/crossbow/runs/3203443397?check_suite_focus=true#step:7:192

@nirandaperera
Copy link
Contributor Author

@github-actions crossbow submit test-r-linux-as-cran

@github-actions
Copy link

Revision: 85fc161

Submitted crossbow builds: ursacomputing/crossbow @ actions-680

Task Status
test-r-linux-as-cran Github Actions

@nirandaperera
Copy link
Contributor Author

@nealrichardson I think this is fine now! :-)

nealrichardson
nealrichardson approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you! 🙏

nealrichardson pushed a commit to nealrichardson/arrow that referenced this pull request Aug 5, 2021
@nirandaperera @nealrichardson
ARROW-13493 [C++] Anonymous structs in an anonymous union are a GNU e…
0e41d80 
…xtension

Closes apache#10833 from nirandaperera/ARROW-13493

Authored-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
@asfimport asfimport mentioned this pull request Jul 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nealrichardson nealrichardson nealrichardson approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nirandaperera @nealrichardson