Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-254: remove Bit type as it is redundant with Boolean #116

Closed

Conversation

julienledem
Copy link
Member

The only use of Bit is for the nullability (or validity) vector which is best understood as a boolean type.
We should remove it as it is not used.

@jacques-n
Copy link
Contributor

LGTM +1

@wesm
Copy link
Member

wesm commented Aug 11, 2016

+1. The Java build is failing for some reason

@julienledem julienledem force-pushed the arrow_254_remove_bit_type branch from f1ca157 to 1cada12 Compare August 11, 2016 23:18
@julienledem
Copy link
Member Author

retriggering the build...

@jihoonson
Copy link
Contributor

jihoonson commented Aug 12, 2016

I'm also suffering from this error, and found the reason. The BaseValueVector.MAX_ALLOCATION_SIZE value used in TestValueVector is declared as a static variable which means its value is initialized when the BaseValueVector class is loaded. Obviously, changing BaseValueVector.MAX_ALLOCATION_SIZE by setting the "arrow.vector.max_allocation_bytes" property in TestValueVector doesn't work. As a result, this test tries to allocate a very large array of the size of Integer.MAX_VALUE, which causes OOM.

I think that this test looks fragile, and thus we need to make the allocation size small. However, reducing the allocation size causes another problem. Many tests in TestValueVector expect the OversizedAllocationException when value allocation reaches to MAX_VALUE_ALLOCATION. So, reducing the allocation size makes OversizedAllocation tests difficult.

I would like to separate all these OversizedAllocation tests, but not sure this is a right way. Please give me some help.

@julienledem
Copy link
Member Author

@jihoonson I created a JIRA for this: https://issues.apache.org/jira/browse/ARROW-260

@asfgit asfgit closed this in 2742d37 Aug 12, 2016
@julienledem julienledem deleted the arrow_254_remove_bit_type branch August 12, 2016 22:59
zhouyuan pushed a commit to zhouyuan/arrow that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants