ARROW-14839 [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error #11796
Conversation
|
@github-actions crossbow submit test-fedora-r-clang-sanitizer |
|
|
|
Revision: b938a2a Submitted crossbow builds: ursacomputing/crossbow @ actions-1215
|
|
@github-actions crossbow submit test-fedora-r-clang-sanitizer |
|
Revision: e40ea9e Submitted crossbow builds: ursacomputing/crossbow @ actions-1216
|
cpp/thirdparty/versions.txt
Outdated
| @@ -123,7 +123,7 @@ DEPENDENCIES=( | |||
| "ARROW_PROTOBUF_URL protobuf-${ARROW_PROTOBUF_BUILD_VERSION}.tar.gz https://github.com/google/protobuf/releases/download/${ARROW_PROTOBUF_BUILD_VERSION}/protobuf-all-${ARROW_PROTOBUF_BUILD_VERSION:1}.tar.gz" | |||
| "ARROW_RAPIDJSON_URL rapidjson-${ARROW_RAPIDJSON_BUILD_VERSION}.tar.gz https://github.com/miloyip/rapidjson/archive/${ARROW_RAPIDJSON_BUILD_VERSION}.tar.gz" | |||
| "ARROW_RE2_URL re2-${ARROW_RE2_BUILD_VERSION}.tar.gz https://github.com/google/re2/archive/${ARROW_RE2_BUILD_VERSION}.tar.gz" | |||
| "ARROW_SNAPPY_URL snappy-${ARROW_SNAPPY_BUILD_VERSION}.tar.gz https://github.com/google/snappy/archive/${ARROW_SNAPPY_BUILD_VERSION}.tar.gz" | |||
| "ARROW_SNAPPY_URL snappy-${ARROW_SNAPPY_BUILD_VERSION}.tar.gz https://codeload.github.com/google/snappy/tar.gz/master" | |||
There was a problem hiding this comment.
Can you point to a specific commit? Won't this break (the checksum) as soon as another commit is added to master?
There was a problem hiding this comment.
Yes, if I can get this to work, that is what we'll need to do (or roll our own snappy "release" that we host)
|
@github-actions crossbow submit test-fedora-r-clang-sanitizer |
|
Revision: bcc4fe5 Submitted crossbow builds: ursacomputing/crossbow @ actions-1223
|
|
Opened PR google/snappy#148 for Snappy so that we can update to upstream git master when merged. |
|
Thank you @pitrou ! I've undone some of the stuff I did in my testing, and now we've got passing builds. I'll run a full r group run to confirm this isn't doing something else funny on any of the more exotic architectures and then merge. |
|
@github-actions crossbow submit -g r |
|
Revision: d8845e4 Submitted crossbow builds: ursacomputing/crossbow @ actions-1224
|
|
Uh, we should wait for the Snappy change to be merged before updating this. I don't think we want to fetch Snappy from some random third-party fork. |
|
Could we put it into the ursa-labs thirdparty repo where we've put some of these before? Looking through the PRs (open and closed) upstream I'm a bit worried it'll take a while for it to be merged. |
|
The following failures in the group are all explained elsewhere: homebrew-r-autobrew — failing on arrow@HEAD / in the nightlies, https://issues.apache.org/jira/browse/ARROW-14802 And the conda-* builds are also failing arrow@HEAD, https://issues.apache.org/jira/browse/ARROW-14256 |
|
Ok, I've got an alternative that patches snappy 1.1.9 instead of using a special self-hosted version of snappy in #11875 I'm happy to do either that PR or this one (well, after we find a way to host our custom patched snappy source). But would like to merge one or the other so we have some clean clang sanitizer CI in the weeks leading up to the release burn down. |
|
I'm ok with the patch solution. |
…ppy causing a sanitizer error This would replace (temporarily) #11796 in a way that might be ship-able as is until Snappy accepts google/snappy#148 and is released. Closes #11875 from jonkeane/ARROW-14839-two Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
No description provided.