-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-15372: [C++][Gandiva] Gandiva now depends on boost/crc.hpp which is missing from the trimmed boost archive #12190
Conversation
|
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled First try to reproduce the error. |
Revision: 228fbdf Submitted crossbow builds: ursacomputing/crossbow @ actions-1404
|
Issue reproduced, need to update the trimmed boost archive. |
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled Testing with the updated boost tarball |
Revision: 9b9282f Submitted crossbow builds: ursacomputing/crossbow @ actions-1405
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@@ -364,6 +364,9 @@ foreach(_VERSION_ENTRY ${TOOLCHAIN_VERSIONS_TXT}) | |||
set(${_VARIABLE_NAME} ${_VARIABLE_VALUE}) | |||
endforeach() | |||
|
|||
set(THIRDPARTY_MIRROR_URL | |||
"https://github.com/ursa-labs/thirdparty/releases/download/apache-arrow-7.0.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use https://apache.jfrog.io/artifactory/arrow/thirdparty here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, but the boost tarball there is the previous trimmed version.
I was thinking to keep the github mirror so we can see how reliable jfrog is after the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. It makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I've just set up the jfrog directory, so we can just simply switch to that.
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled Let's try out artifactory. |
Revision: 575896e Submitted crossbow builds: ursacomputing/crossbow @ actions-1407
|
Benchmark runs are scheduled for baseline = a061c4c and contender = c535878. c535878 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
See build error https://github.com/ursacomputing/crossbow/runs/4871392838?check_suite_focus=true#step:5:11762