-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-16719: [Python] Add path/URI + filesystem handling to parquet.read_metadata #13629
Merged
jorisvandenbossche
merged 19 commits into
apache:master
from
kshitij12345:develop/fs/read_schema-metadata
Aug 17, 2022
Merged
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
02a7f09
ARROW-16719: [Python] Add path/URI /+ filesystem handling to parquet.…
kshitij12345 0abe1df
update path in test
kshitij12345 4a18fe2
pass filesystem arg
kshitij12345 25dde91
update test
kshitij12345 3efca03
remove stray files
kshitij12345 9580c5a
make linter happy
kshitij12345 7d3b42f
address review: use open_input_file with contextmanager
kshitij12345 970ac49
fix error
kshitij12345 bc3ec3e
fix linter : unused import
kshitij12345 67f444e
fix : filesystem can be None
kshitij12345 26199da
Merge branch 'master' into develop/fs/read_schema-metadata
kshitij12345 c855deb
address review
kshitij12345 d5ebecb
Merge branch 'develop/fs/read_schema-metadata' of https://github.com/…
kshitij12345 4d8e0fa
address review : filesystem -> fs
kshitij12345 c4dba6e
remove get_instance case
kshitij12345 105efa9
Merge branch 'master' of https://github.com/apache/arrow into develop…
kshitij12345 6b7bab1
update error msg
kshitij12345 5a63f4b
fix linter errors
kshitij12345 f9e36d8
use our own tempdir instead of tmpdir
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new LocalFileSystem has no
get_instance()
method, so I think you can just remove this case (since the line above already includes the case of a plain LocalFileSystem())There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I was away from keyboard for the week. Will fix it!