ARROW-16782: [Format] Add REE definitions to FlatBuffers #14176
Conversation
zeroshade
changed the title
There was a problem hiding this comment.
FBS change looks good to me -- thank you @zagto
Is it possible to incorporate the documentation from #13333 into this pR as well so that the new changes are documented?
For anyone following along, see https://lists.apache.org/thread/539scy67qom5t2fkkd1m6fvh5htvwo3s discussion for more context
cc @zeroshade
+1 on this. It will also make reviewing easier. |
zeroshade
force-pushed
the
rle-flatbuffers
branch
from
c664ab7 to
658ca1d
Compare
|
@github-actions crossbow submit preview-docs EDIT: this PR was old, I've rebased it now and am going to make this comment again so it should work now. |
|
Co-authored-by: Weston Pace <weston.pace@gmail.com>
(code already works like this)
|
@westonpace I've updated with a line prescribing the standard names for the children and updated the example layout to add the underscore so that it uses those standard names Once I get some explicit approvals on this I'll merge it in. |
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
|
General question here: how are we going to handle versioning of the Arrow specification? Are we going to merge this and down the line release an "Arrow specification 1.1.0"/MetadataVersion.V6 once we also have types like StringView, or are we going to bump these versions for each new type? |
|
That is a very good question @lidavidm. What do you think @westonpace @pitrou @alamb @ianmcook ? |
|
I think we only increase As for the format version, we should perhaps bump it: |
|
@pitrou I can bump it in the docs in this PR, but do we need to do a vote on the mailing list or anything to make the new version official? |
|
I don't think a new vote is needed, though I don't know for sure. |
|
I suppose the version bump is implicit in adding a new data type? Looking at the Git history/the MONTH_DAY_NANO PR, the versions were just bumped when we added the type. (...And 1.2 is still "pending", guess we should take that out now and put 1.3 as adding REE.) |
|
I've updated the I've got two approvals here, so unless someone comments otherwise I'll merge this after EOD today, to give people a chance to add any final comments. Thanks everyone! |
| @@ -19,8 +19,9 @@ | |||
|
|
|||
| /// Format Version History. | |||
| /// Version 1.0 - Forward and backwards compatibility guaranteed. | |||
| /// Version 1.1 - Add Decimal256 (No format release). | |||
| /// Version 1.2 (Pending)- Add Interval MONTH_DAY_NANO | |||
| /// Version 1.1 - Add Decimal256. | |||
|
Benchmark runs are scheduled for baseline = d0ffedb and contender = 3146588. 3146588 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.