MINOR: [C++] Use the array returned by TweakValidityBit

[kshitij12345]

TweakValidityBit returns a new Array so the calling function should use it.

arrow/cpp/src/arrow/testing/gtest_util.cc

Lines 568 to 579 in 6cc37cf

	std::shared_ptr<Array> TweakValidityBit(const std::shared_ptr<Array>& array,
	int64_t index, bool validity) {
	auto data = array->data()->Copy();
	if (data->buffers[0] == nullptr) {
	data->buffers[0] = *AllocateBitmap(data->length);
	bit_util::SetBitsTo(data->buffers[0]->mutable_data(), 0, data->length, true);
	}
	bit_util::SetBitTo(data->buffers[0]->mutable_data(), index, validity);
	data->null_count = kUnknownNullCount;
	// Need to return a new array, because Array caches the null bitmap pointer
	return MakeArray(data);
	}

[github-actions]

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

• Other pull requests
• Contribution Guidelines - How to contribute patches

[kshitij12345]

cc: @lidavidm @pitrou (original author of the test)

[lidavidm]

Thanks for catching this!

[ursabot]

Benchmark runs are scheduled for baseline = cc76736 and contender = f941118. f941118 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️2.76% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.25% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] f941118e ec2-t3-xlarge-us-east-2
[Failed] f941118e test-mac-arm
[Failed] f941118e ursa-i9-9960x
[Finished] f941118e ursa-thinkcentre-m75q
[Finished] cc767365 ec2-t3-xlarge-us-east-2
[Finished] cc767365 test-mac-arm
[Failed] cc767365 ursa-i9-9960x
[Finished] cc767365 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java