Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17830: [C++][Gandiva] Temporarily pin LLVM version on AppVeyor #14228

Merged
merged 2 commits into from
Sep 25, 2022
Merged

ARROW-17830: [C++][Gandiva] Temporarily pin LLVM version on AppVeyor #14228

merged 2 commits into from
Sep 25, 2022

Conversation

js8544
Copy link
Collaborator

@js8544 js8544 commented Sep 24, 2022 •
edited
Loading

Temporarily pin LLVM version on Appveyor due to a bug in Conda's packaging of LLVM.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17830

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@js8544 js8544 force-pushed the jinshang/fix_appveyor_build branch 3 times, most recently from 005ea33 to cba216f Compare September 24, 2022 10:59
@js8544 js8544 changed the title ARROW-17830: [C++][Gandiva]specify MSVC DIA path ARROW-17830: [C++][Gandiva] Disable Gandiva build on Appveyor Sep 24, 2022
@js8544 js8544 closed this Sep 24, 2022
@js8544 js8544 force-pushed the jinshang/fix_appveyor_build branch from cba216f to 356e7f8 Compare September 24, 2022 11:47
@js8544 js8544 reopened this Sep 24, 2022
@js8544 js8544 force-pushed the jinshang/fix_appveyor_build branch from e7cb9d1 to 1624e9d Compare September 24, 2022 11:51
@js8544
Copy link
Collaborator Author

js8544 commented Sep 24, 2022 •
edited
Loading

Sent an issue to conda llvm: conda-forge/llvmdev-feedstock#175

@js8544
Copy link
Collaborator Author

js8544 commented Sep 24, 2022

@lidavidm Appveyor is green now.

@kou
Copy link
Member

kou commented Sep 24, 2022

How about pinning LLVM to old version instead?

diff --git a/ci/conda_env_gandiva_win.txt b/ci/conda_env_gandiva_win.txt
index 621b6f5a99..138b9bd200 100644
--- a/ci/conda_env_gandiva_win.txt
+++ b/ci/conda_env_gandiva_win.txt
@@ -15,5 +15,6 @@
 # specific language governing permissions and limitations
 # under the License.
 
-clangdev
-llvmdev
+# ARROW-17830: Conda's packaging of LLVM 15 have a bug
+clangdev<15
+llvmdev<15

@js8544 js8544 changed the title ARROW-17830: [C++][Gandiva] Disable Gandiva build on Appveyor ARROW-17830: [C++][Gandiva] Temporarily pin LLVM version on Appveyor Sep 25, 2022
@js8544
Copy link
Collaborator Author

js8544 commented Sep 25, 2022

How about pinning LLVM to old version instead?

diff --git a/ci/conda_env_gandiva_win.txt b/ci/conda_env_gandiva_win.txt
index 621b6f5a99..138b9bd200 100644
--- a/ci/conda_env_gandiva_win.txt
+++ b/ci/conda_env_gandiva_win.txt
@@ -15,5 +15,6 @@
 # specific language governing permissions and limitations
 # under the License.
 
-clangdev
-llvmdev
+# ARROW-17830: Conda's packaging of LLVM 15 have a bug
+clangdev<15
+llvmdev<15

@kou Done.

kou
kou approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou changed the title ARROW-17830: [C++][Gandiva] Temporarily pin LLVM version on Appveyor ARROW-17830: [C++][Gandiva] Temporarily pin LLVM version on AppVeyor Sep 25, 2022
@kou kou merged commit 7808280 into apache:master Sep 25, 2022
@js8544 js8544 deleted the jinshang/fix_appveyor_build branch September 25, 2022 10:59
@ursabot
Copy link

ursabot commented Sep 25, 2022

Benchmark runs are scheduled for baseline = b2871bb and contender = 7808280. 7808280 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.51% ⬆️0.14%] test-mac-arm
[Failed ⬇️0.55% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.36% ⬆️0.11%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 78082800 ec2-t3-xlarge-us-east-2
[Failed] 78082800 test-mac-arm
[Failed] 78082800 ursa-i9-9960x
[Finished] 78082800 ursa-thinkcentre-m75q
[Finished] b2871bb4 ec2-t3-xlarge-us-east-2
[Failed] b2871bb4 test-mac-arm
[Failed] b2871bb4 ursa-i9-9960x
[Finished] b2871bb4 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Sep 25, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@js8544 @zagto
ARROW-17830: [C++][Gandiva] Temporarily pin LLVM version on AppVeyor (a…
2756b9b 
…pache#14228)

Temporarily pin LLVM version on Appveyor due to a bug in Conda's packaging of LLVM.

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@js8544 @fatemehp
ARROW-17830: [C++][Gandiva] Temporarily pin LLVM version on AppVeyor (a…
f4185b9 
…pache#14228)

Temporarily pin LLVM version on Appveyor due to a bug in Conda's packaging of LLVM.

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@asfimport asfimport mentioned this pull request Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@js8544 @kou @ursabot